[Refactor]: Move sources into subdirectories #2119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caellian
added
the
enhancement
✅ Deploy Preview for conkyweb canceled.
|
Caellian
force-pushed
the
dev/move-files
branch
from
5042138 to
f6efceb
Compare
|
@brndnmtthws can you please confirm whether I should continue with this PR? I made sure to separate commit with renames so this PR can be hidden in The only important thing is that you'd need to merge the commits without squashing because squashing them will make git fumble renames - I will have to modify files to update imports. I'll make sure there's only 2 to keep the |
Caellian
added a commit
that referenced
this pull request
Dec 16, 2024
Part 1 of refactor commit. This commit only renames the files to preserve git history. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
dev/move-files
branch
from
f6efceb to
0499a7e
Compare
Part 1 of refactor commit. This commit only renames the files to preserve git history. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
dev/move-files
branch
from
0499a7e to
ef6feef
Compare
brndnmtthws
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor that moves sources from
src/directory into appropriate subdirectories.This PR contains no functional changes.
I wanted to do this ever since my first commit 😆, but yeah, I feel like the
src/directory is too crowded and very difficult to navigate. To the extent that it takes me a minute of scrolling sometimes before I can find the source file I'm looking for - and I'm familiar with this project.When I first started I remember having to navigate though include statements.
TODO