-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notebooks #35
Fix notebooks #35
Conversation
The Pluto built-in package manager could not arrive at a solution because the Opticsim release it picks up (0.5.3) does not have the required fixes.
Bonito now sets the port automatically.
The replacement of Vis.scene is then no longer necessary, as Vis.scene bypasses the buttons layout stuff when current mode is :pluto or :docs.
Minimal change to adapt to Makie 0.20.
Minimal change to adapt to Makie 0.20, while keeping the current OpticSim.Vis API.
This line errored with Makie 0.20, and the comment said it didn't seem to work anyway.
The Pluto built-in package manager could not arrive at a solution because the Opticsim release it picks up (0.5.3) does not have the required fixes.
The replacement of Vis.scene is then no longer necessary, as Vis.scene bypasses the buttons layout stuff when current mode is :pluto or :docs.
The Pluto built-in package manager could not arrive at a solution because the Opticsim release it picks up (0.5.3) does not have the required fixes.
The replacement of Vis.scene is then no longer necessary, as Vis.scene bypasses the buttons layout stuff when current mode is :pluto or :docs.
ubuntu-18.04 is no longer available on github CI.
Documentation failed because there were no runners:
=> updated to |
Note: those are just notes explaining why I'm making seemingly strange changes, Doc CI fails with ERROR: Unsatisfiable requirements detected for package SHA [ea8e919c]:
SHA [ea8e919c] log:
├─possible versions are: 1.1.1 or uninstalled
└─restricted to versions 0.7.0-0.7 by OpticSim [24114763] — no versions left From JuliaCrypto/SHA.jl#87 (comment):
[see below, on 1.10 it is possible to install SHA@0.7, and it is still the latest version] So let's remove SHA from compat ? (OpticSim) pkg> rm SHA
Updating `~/share/prog/julia/dev/OpticSim.jl/Project.toml`
[ea8e919c] - SHA v0.7.0
No Changes to `~/share/prog/julia/dev/OpticSim.jl/Manifest.toml`
(OpticSim) pkg> add SHA
Updating registry at `~/.julia/registries/General.toml`
Resolving package versions...
Updating `~/share/prog/julia/dev/OpticSim.jl/Project.toml`
[ea8e919c] + SHA v0.7.0
No Changes to `~/share/prog/julia/dev/OpticSim.jl/Manifest.toml` Nope, 0.7.0 is still the most recent SHA version. Besides, it is possible to use SHA@0.7 (it is actually the one bundled with julia-1.10): (@v1.10) pkg> activate --temp
Activating new project at `/tmp/jl_Aex54p`
julia> using SHA
julia> pkgversion(SHA)
v"0.7.0"
(jl_Aex54p) pkg> add SHA@0.7 Works fine. Then why did the CI say "possible versions are: 1.1.1 or uninstalled" ? Let me push the change anyway to see if there is any difference. EDIT: note that github shows the commits before this comment |
Note: tests passed with julia-1.8 on linux, but 1.8 was removed from CI recently. brianguenter#34 (comment)
Still fails; CI logRun xvfb-run julia --project=docs/ -e '
Cloning default registries into `~/.julia`
Cloning registry from "https://github.com/JuliaRegistries/General.git"
25l Fetching: [> ] 0.0 %
Fetching: [=====> ] 10.1 %
Fetching: [==============> ] 34.3 %
Fetching: [===========================> ] 66.9 %
Fetching: [=====================================> ] 90.8 %
25h Added registry `General` to `~/.julia/registries/General`
Resolving package versions...
┌ Warning: julia version requirement for package OpticSim not satisfied
└ @ Pkg.Operations /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/Operations.jl:154
ERROR: Unsatisfiable requirements detected for package SHA [ea8e919c]:
SHA [ea8e919c] log:
├─possible versions are: 1.1.1 or uninstalled
├─restricted to versions * by OpticSim [24114763], leaving only versions 1.1.1
│ └─OpticSim [24114763] log:
│ ├─possible versions are: 0.6.0 or uninstalled
│ └─OpticSim [24114763] is fixed to version 0.6.0
└─found to have no compatible versions left with Bonito [824d6782]
└─Bonito [824d6782] log:
├─possible versions are: [3.0.0-3.0.7, 3.1.0-3.1.2] or uninstalled
└─restricted to versions * by OpticSim [24114763], leaving only versions [3.0.0-3.0.7, 3.1.0-3.1.2]
└─OpticSim [24114763] log: see above
Stacktrace:
[1] #propagate_constraints!#61(::Bool, ::Function, ::Pkg.GraphType.Graph, ::Set{Int64}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/GraphType.jl:1007
[2] propagate_constraints! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/GraphType.jl:948 [inlined]
[3] #simplify_graph!#121(::Bool, ::Function, ::Pkg.GraphType.Graph, ::Set{Int64}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/GraphType.jl:1462
[4] simplify_graph! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/GraphType.jl:1462 [inlined] (repeats 2 times)
[5] resolve_versions!(::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}, ::Nothing) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/Operations.jl:371
[6] resolve_versions! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/Operations.jl:315 [inlined]
[7] #add_or_develop#63(::Array{Base.UUID,1}, ::Symbol, ::Function, ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/Operations.jl:1172
[8] #add_or_develop at ./none:0 [inlined]
[9] #add_or_develop#17(::Symbol, ::Bool, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/API.jl:59
[10] #add_or_develop at ./none:0 [inlined]
[11] #add_or_develop#16 at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/API.jl:36 [inlined]
[12] #add_or_develop at ./none:0 [inlined]
[13] #add_or_develop#12 at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/API.jl:33 [inlined]
[14] #add_or_develop at ./none:0 [inlined]
[15] #develop#23 at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/API.jl:65 [inlined]
[16] develop(::Pkg.Types.PackageSpec) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.1/Pkg/src/API.jl:65
[17] top-level scope at none:0 Note the
and some The Documenter.jl documentation Indeed, that's julia-actions/setup-julia#204 |
OK, it now goes further but got stuck for more than one hour after installing GLMakie: Let me revert 9a8d8f4 (it was not the culprit) to trigger the doc build again. |
This reverts commit 9a8d8f4.
And it did it again: CI log
OK, this might be related to MakieOrg/Makie.jl#3766 (comment) which
So time to update to Makie 0.20 to the latest, 0.21.
I'll look into this in the next few days. |
Do you want me to approve and merge this batch of changes in the meantime before you get the fix for Makie, or would you prefer to do it all at once later? |
In the current state ( EDIT (for other readers): |
The julia-1.8 removal from CI comes from #34 (comment) (just forgot to push back then).
Until 70197f4 can be reverted (or improved upon),
one needs a valid project.
For notebooks development, here is how I proceed
then
With the other changes the Pluto notebook
samples/notebooks/EmittersIntro.jl
now executes without any error,and all Makie-related warnings have been silenced as well.
samples/notebooks/BasicCSG.jl
still errors withAnd
samples/notebooks/Samples.jl
has two errors:and
Those errors seem related to changes in OptimSim rather than Makie or julia, so I'd leave them for later.