[AI Chat] cleanup suggestion action types #27077
Merged
+757
−427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/storybook-url
petemill
force-pushed
the
ai-chat-suggestion-cleanup
branch
from
90b79eb to
55df777
Compare
petemill
commented
Dec 20, 2024
Comment on lines
44
to
52
| bool MigrateFrom1To2(sql::Database* db) { | ||
| // Add a new column to the associated_content table to store the content type. | ||
| static constexpr char kAddPromptColumnQuery[] = | ||
| "ALTER TABLE conversation_entry ADD COLUMN prompt BLOB " | ||
| "0"; | ||
| sql::Statement statement(db->GetUniqueStatement(kAddPromptColumnQuery)); | ||
|
|
||
| return statement.is_valid() && statement.Run(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Database migration and tests
petemill
force-pushed
the
ai-chat-suggestion-cleanup
branch
from
55df777 to
baabfdb
Compare
|
A Storybook has been deployed to preview UI for the latest push |
petemill
force-pushed
the
ai-chat-suggestion-cleanup
branch
3 times, most recently
from
1cd6ada to
8878883
Compare
DJAndries
reviewed
Dec 20, 2024
| @@ -149,6 +148,8 @@ enum ActionType { | |||
| // Change length | |||
| SHORTEN, | |||
| EXPAND, | |||
| CONVERSATION_STARTER, | |||
| SUGGESTION, | |||
There was a problem hiding this comment.
could you clarify what the difference is between a starter and a suggestion? are starters only be used when making the first prompt in the chat, and suggestions used for follow-ups?
There was a problem hiding this comment.
A suggestion is generated by the LLM and is about the specific page content. A conversation starter is static and yes, only for the first message
DJAndries
approved these changes
Jan 7, 2025
Brandon-T
approved these changes
Jan 16, 2025
petemill
force-pushed
the
ai-chat-suggestion-cleanup
branch
from
8878883 to
ecf087d
Compare
|
A Storybook has been deployed to preview UI for the latest push |
petemill
force-pushed
the
ai-chat-suggestion-cleanup
branch
4 times, most recently
from
0160e6d to
44fa26e
Compare
|
[puLL-Merge] - brave/brave-core@27077 DescriptionThis PR makes significant changes to the AI chat functionality in Brave, primarily focusing on conversation turn handling and database structure. The main changes include:
The motivation appears to be improving the conversation model by separating displayed text from actual prompts sent to the AI, while also improving the handling of suggested questions. ChangesChangesCore Changes:
Engine Changes:
UI Changes:
sequenceDiagram
participant UI
participant ConversationHandler
participant EngineConsumer
participant Database
UI->>ConversationHandler: submitSuggestion(text)
ConversationHandler->>ConversationHandler: CreateConversationTurn
Note over ConversationHandler: Add prompt & text fields
ConversationHandler->>EngineConsumer: GenerateAssistantResponse
EngineConsumer->>EngineConsumer: GetPromptForEntry
EngineConsumer-->>ConversationHandler: Response
ConversationHandler->>Database: AddConversationEntry
Database->>Database: EncryptAndStore
Database-->>ConversationHandler: Success
ConversationHandler-->>UI: Update
Security Hotspots
|
…n prompt differs from user-visible conversation entry text
- ActionType::CONVERSATION_STARTER
- ActionType::SUGGESTION
- ActionType::SUMMARIZE_{PAGE,VIDEO}
petemill
force-pushed
the
ai-chat-suggestion-cleanup
branch
from
44fa26e to
07de4a4
Compare
|
Released in v1.76.36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and persist to database when prompt differs from user-visible conversation entry text
ActionType::CONVERSATION_STARTERActionType::SUGGESTIONActionType::SUMMARIZE_{PAGE,VIDEO}I believe this unblocks the following to be able to get the source of each user submission more easily:
Issues:
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: