Skip to content

[Tabs]: We should subclass TabFeatures with a new BraveTabFeatures class to make it easier to add new features #43437

Closed
brave/brave-core
#27322
@fallaciousreasoning

Description

Upstream has changed their recommended best practices, so we shouldn't be introducing any new TabHelpers. This will make doing things the new way much simpler in Brave.

https://chromium.googlesource.com/chromium/src/+/refs/tags/128.0.6613.5/docs/chrome_browser_design_principles.md

At its most simple level:

  • New code should not introduce new TabHelpers
  • New code should (ideally) not depend on Browser
  • The new way of doing things is to add a unique_ptr<YourClass> to the TabFeatures

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions