2.104.1

braintree · Oct 12, 2020 · 295b40a · 295b40a
1 parent dae568f
commit 295b40a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 2.104.1
+
+* Update `LocalPaymentCompleted` webhook to handle no transaction being created for unbranded local payment methods
+
 ## 2.104.0
 
 * Deprecate Masterpass and American Express Checkout payment methods.

diff --git a/lib/braintree/local_payment_completed.rb b/lib/braintree/local_payment_completed.rb
@@ -9,7 +9,7 @@ class LocalPaymentCompleted
 
     def initialize(attributes) # :nodoc:
       set_instance_variables_from_hash(attributes)
-      @transaction = Transaction._new(Configuration.gateway, transaction)
+      @transaction = Transaction._new(Configuration.gateway, transaction) unless transaction.nil?
     end
 
     class << self

diff --git a/lib/braintree/version.rb b/lib/braintree/version.rb
@@ -2,7 +2,7 @@ module Braintree
   module Version
     Major = 2
     Minor = 104
-    Tiny = 0
+    Tiny = 1
 
     String = "#{Major}.#{Minor}.#{Tiny}"
   end

diff --git a/spec/unit/braintree/local_payment_completed_spec.rb b/spec/unit/braintree/local_payment_completed_spec.rb
@@ -32,5 +32,19 @@
       local_payment_completed.transaction.order_id.should eq("an-order-id")
       local_payment_completed.transaction.status.should eq(Braintree::Transaction::Status::Authorized)
     end
+
+    it "initializes the object with the appropriate attributes set if no transaction is provided" do
+      params = {
+        payment_id: "a-payment-id",
+        payer_id: "a-payer-id",
+        payment_method_nonce: "a-nonce",
+      }
+      local_payment_completed = Braintree::LocalPaymentCompleted._new(params)
+
+      local_payment_completed.payment_id.should eq("a-payment-id")
+      local_payment_completed.payer_id.should eq("a-payer-id")
+      local_payment_completed.payment_method_nonce.should eq("a-nonce")
+      local_payment_completed.transaction.should be_nil
+    end
   end
 end