New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React Context API for detecting nested components, ie. in Dialog component #2795

Closed

matzimowski opened this issue Jan 16, 2024 · 1 comment

Contributor

matzimowski commented Jan 16, 2024

instead of accessing DOM to find nested components, ie:

const isNestedDialog = overlayRef.current?.parentElement?.closest(DIALOG_SELECTOR);

use React Context API

good read: https://www.aleksandrhovhannisyan.com/blog/react-context-nested-components/

The text was updated successfully, but these errors were encountered:

matzimowski mentioned this issue

Dialog - useBodyOnScroll - Fix for nested dialogs case #2794

Merged

Contributor

Malinicz commented Dec 4, 2024

Closing due to fix that doesn't require context usage, ref: #2821

Malinicz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment