Update ROS package.xml format to v3 and update gtsam version (develop branch) #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Jan 29, 2023
| <name>gtsam</name> | ||
| <version>4.1.0</version> | ||
| <version>4.3.0</version> |
There was a problem hiding this comment.
Should this be 4.3a0 ? That and 4.2 will be the tags going to master soon...
|
PS, don't push to the branch until we agree on right version above - I am trying to fix something for gtbook and I'm blocked on CI cycles. |
|
I ran required CI and merged. If the version is wrong let me know and I can sneak it into my next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1421