Update ROS package.xml format to v3 #1421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Jan 28, 2023
There was a problem hiding this comment.
Thanks @jlblancoc . Yes, 4.1.1 is still the latest official release, although I am hoping that will change. When you see the PR for that and you don't see the version chnage, please remind me :-)
|
Before I merge, though: should this not be a patch on 4.1.1 in master? And in release/4.2 it should be 4.2.0, and in develop 4.3.0? |
|
Yes, it makes sense. Will open the alternative PRs for each branch. |
This was referenced Jan 28, 2023
|
Let's then punt on master - soon it will have the latest 4.3a0 tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package.xml to format v3.
Also, update the version to 4.1.1 since that seems to be the last stable release... is this correct? Anyhow, that
<version>line should be updated just before the next release so its contents remain consistent when tagging the repository.