Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests: cover cmake-based building of user program #333

Open
jlblancoc opened this issue Jun 2, 2020 · 3 comments
Open

Unit tests: cover cmake-based building of user program #333

jlblancoc opened this issue Jun 2, 2020 · 3 comments
Labels
enhancement Improvement to GTSAM help wanted Need help and/or clarification

Comments

@jlblancoc
Copy link
Member

Feature

It would be great to add a new Unit Test consisting of invoking cmake to build a simple program using the just-generated gtsam*-config.cmake + gtsam*-targets.cmake, etc.

Motivation

Detect bugs regarding exported targets for different build configurations, usage of embedded vs system libraries etc.

Additional context

Related to: #292, #332
@jlblancoc jlblancoc added enhancement Improvement to GTSAM help wanted Need help and/or clarification labels Jun 2, 2020
@tmcg0
Copy link
Contributor

tmcg0 commented Jun 4, 2020 •
edited
Loading

Could this be covered in CI?

@varunagrawal
Copy link
Collaborator

This would be awesome and a separate "test suite" I guess? We already have a Matlab wrapper Hello World example, adding a python and C++ version and just having CMake build and call those (very doable from experience) would be of tremendous value.

@jlblancoc
Copy link
Member Author

Could this be covered in CI?

At least testing it in one or two systems/configurations would be great :-)
As @varunagrawal says, "all" that is required is to call cmake a couple of times and check its process numeric result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to GTSAM help wanted Need help and/or clarification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@varunagrawal @jlblancoc @tmcg0