Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of global state in carbonapi app tests #237

Open
grzkv opened this issue Jan 29, 2020 · 0 comments
Open

Get rid of global state in carbonapi app tests #237

grzkv opened this issue Jan 29, 2020 · 0 comments
Assignees

Comments

@grzkv
Copy link
Member

grzkv commented Jan 29, 2020

Currently, the key tests in carbonapi depend on global variables

var testApp *App

This makes the test results depend on test order and requires implicit operations. The global state needs to be removed and replaced with a local one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants