Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #267

Merged
merged 1 commit into from
Aug 14, 2022
Merged

typos #267

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions backward.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
// #define BACKWARD_HAS_UNWIND 1
// - unwind comes from libgcc, but I saw an equivalent inside clang itself.
// - with unwind, the stacktrace is as accurate as it can possibly be, since
// this is used by the C++ runtine in gcc/clang for stack unwinding on
// this is used by the C++ runtime in gcc/clang for stack unwinding on
// exception.
// - normally libgcc is already linked to your program by default.
//
Expand Down Expand Up @@ -277,7 +277,7 @@
// #define BACKWARD_HAS_UNWIND 1
// - unwind comes from libgcc, but I saw an equivalent inside clang itself.
// - with unwind, the stacktrace is as accurate as it can possibly be, since
// this is used by the C++ runtine in gcc/clang for stack unwinding on
// this is used by the C++ runtime in gcc/clang for stack unwinding on
// exception.
// - normally libgcc is already linked to your program by default.
//
Expand Down Expand Up @@ -838,7 +838,7 @@ template <typename F> class Unwinder {
uintptr_t ip = _Unwind_GetIPInfo(ctx, &ip_before_instruction);

if (!ip_before_instruction) {
// calculating 0-1 for unsigned, looks like a possible bug to sanitiziers,
// calculating 0-1 for unsigned, looks like a possible bug to sanitizers,
// so let's do it explicitly:
if (ip == 0) {
ip = std::numeric_limits<uintptr_t>::max(); // set it to 0xffff... (as
Expand Down Expand Up @@ -1460,7 +1460,7 @@ class TraceResolverLinuxImpl<trace_resolver_tag::libbfd>
// line of the function that was called. But if the code is optimized,
// we might get something absolutely not related since the compiler
// can reschedule the return address with inline functions and
// tail-call optimisation (among other things that I don't even know
// tail-call optimization (among other things that I don't even know
// or cannot even dream about with my tiny limited brain).
find_sym_result details_adjusted_call_site = find_symbol_details(
fobj, (void *)(uintptr_t(trace.addr) - 1), symbol_info.dli_fbase);
Expand Down Expand Up @@ -1491,7 +1491,7 @@ class TraceResolverLinuxImpl<trace_resolver_tag::libbfd>
// this time we get the name of the function where the code is
// located, instead of the function were the address is
// located. In short, if the code was inlined, we get the
// function correspoding to the code. Else we already got in
// function corresponding to the code. Else we already got in
// trace.function.
trace.source.function = demangle(details_selected->funcname);

Expand Down Expand Up @@ -1706,7 +1706,7 @@ class TraceResolverLinuxImpl<trace_resolver_tag::libbfd>

// are we in the boundaries of the section?
if (addr < sec_addr || addr >= sec_addr + size) {
addr -= base_addr; // oups, a relocated object, lets try again...
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"oups" is the French spelling of "oops" ;)

addr -= base_addr; // oops, a relocated object, lets try again...
if (addr < sec_addr || addr >= sec_addr + size) {
return;
}
Expand Down Expand Up @@ -4372,7 +4372,7 @@ class SignalHandling {
static const constexpr int signal_skip_recs =
#ifdef __clang__
// With clang, RtlCaptureContext also captures the stack frame of the
// current function Below that, there ar 3 internal Windows functions
// current function Below that, there are 3 internal Windows functions
4
#else
// With MSVC cl, RtlCaptureContext misses the stack frame of the current
Expand Down