Andrscyv/botserver #1081
Draft
Andrscyv/botserver #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use array of bot player's ids instead of Record<string,any> so that GetBotPlayer function can be reused in botserver. GetBotPlayer was only using the keys of Record<string,any> any way.
For the new endpoint to add bots to a game the same logic is going to be required
This endpoint will publish a message that will trigger botServer to add bots to the game specified
|
Hello! Is there any update on this feature? |
|
What's the current status of this PR? Is there a feature list that this intends to complete? I've been thinking of adding custom bots to my game and want to see if this PR aligns with mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! @delucis
This has taken me way longer than I expected (life got in the way).
I send this draft to get some early feedback. I'm still missing to fix the coverage and actually test it manually end to end but this PR has all the broad strokes of this feature #383 .
Checklist
main).