Merge pull request #350 from j75689/fix/ledger_pubkey_copy

fix: reading pubkey from ledger panic
bnb-chain · Jun 5, 2023 · 8538f32 · 8538f32
2 parents edff400 + 164d949
commit 8538f32
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/crypto/ledger_secp256k1.go b/crypto/ledger_secp256k1.go
@@ -192,13 +192,13 @@ func (pkl PrivKeyLedgerSecp256k1) pubkeyLedgerSecp256k1() (pub tmcrypto.PubKey,
 		return nil, fmt.Errorf("error fetching public key: %v", err)
 	}
 
-	var pk tmsecp256k1.PubKeySecp256k1
-
 	// re-serialize in the 33-byte compressed format
 	cmp, err := btcec.ParsePubKey(key[:])
 	if err != nil {
 		return nil, fmt.Errorf("error parsing public key: %v", err)
 	}
+
+	pk := make(tmsecp256k1.PubKeySecp256k1, tmsecp256k1.PubKeySize)
 	copy(pk[:], cmp.SerializeCompressed())
 
 	return pk, nil