Contribute dns_zoneedit.sh to acme.sh official repo #13
Comments
|
I sure haven't been able to find the time. I basically stopped working on it once it was working good. (2 years ago) It does not fully meet code conformity or integration requirements, but I don't know how picky they will be about that. I think it was mostly variable names or formatting related and I noted that I got it mostly there. (I contributed the rewrite) And I guess ZoneEdit never did follow through with their API changes. |
|
We'll see: acmesh-official/acme.sh#6136 |
|
In the beginning I read the requirements of the acme.sh project but at that time the zonedit api was not complete, so I dropped the idea. When sbn-purchark provided improvement the zoneedit api was enhanced. At that time and since then I didn't had the time to continue. Lukavia you are welcome to give it a shoot. :-) |
|
OK. So the pull request is merged in acmesh-official:dev Do you want to keep this issue open and notify you or should we close it? |
|
Thanks Lukavia. I will leave it open until we know the results. :-) |
|
It's already in master, so it should be included in the next release I would think. |
|
It also would be nice if you can subscribe to the support topic |
I think I have successfully subscribed to the issue. |
Have you considered contributing your code to the official acme.sh project?
That way it would be eventually available in pfsense and opnsense without the need to patch after each update.
If you don't have the time do you mind if I try to make pull request to them following their guides?
Thank you for this wonderful work
The text was updated successfully, but these errors were encountered: