Skip to content

Commit

Permalink
fix: errtrace issues with unwrapping errors (#4051)
Browse files Browse the repository at this point in the history
fixes: #4034
  • Loading branch information
stuartwdouglas authored Jan 15, 2025
1 parent eebf549 commit e034ac8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions common/errors/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ func Innermost(err error) bool {
return true
}

func Join(errs ...error) error { return errors.Join(errs...) }
func Join(errs ...error) error { return errors.Join(errs...) } //errtrace:skip // errtraces messes up error reporting

func New(text string) error { return errors.New(text) }

func As(err error, target interface{}) bool { return errors.As(err, target) }

func Is(err, target error) bool { return errors.Is(err, target) }

func Unwrap(err error) error { return errors.Unwrap(err) }
func Unwrap(err error) error { return errors.Unwrap(err) } //errtrace:skip // errtraces messes up error reporting

// DeduplicateErrors de-duplicates equivalent errors.
func DeduplicateErrors(merr []error) []error {
Expand Down
2 changes: 1 addition & 1 deletion internal/buildengine/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func handleBuildResult(ctx context.Context, projectConfig projectconfig.Config,
}

if len(errs) > 0 {
return nil, nil, errors.Join(errs...)
return nil, nil, errors.Join(errs...) //errtrace:skip // errtraces messes up error reporting
}

logger.Infof("Module built (%.2fs)", time.Since(result.StartTime).Seconds())
Expand Down

0 comments on commit e034ac8

Please sign in to comment.