Merge pull request grpc#4083 from murgatroid99/node_user_agent_position

Ensure application and Node library user agent strings are together at the beginning
bjarnescottlee · Nov 6, 2015 · 8bbc4e0 · 8bbc4e0
2 parents 31ee320 + 1099ace
commit 8bbc4e0
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/node/src/client.js b/src/node/src/client.js
@@ -612,7 +612,15 @@ exports.makeClientConstructor = function(methods, serviceName) {
     if (!options) {
       options = {};
     }
-    options['grpc.primary_user_agent'] = 'grpc-node/' + version;
+    /* Append the grpc-node user agent string after the application user agent
+     * string, and put the combination at the beginning of the user agent string
+     */
+    if (options['grpc.primary_user_agent']) {
+      options['grpc.primary_user_agent'] += ' ';
+    } else {
+      options['grpc.primary_user_agent'] = '';
+    }
+    options['grpc.primary_user_agent'] += 'grpc-node/' + version;
     /* Private fields use $ as a prefix instead of _ because it is an invalid
      * prefix of a method name */
     this.$channel = new grpc.Channel(address, credentials, options);