Fix GenerateName in test #301
Conversation
cmd/controller/main_test.go
Outdated
| func generateNameReactor(action ktesting.Action) (handled bool, ret runtime.Object, err error) { | ||
| s := action.(ktesting.CreateAction).GetObject().(*v1.Secret) | ||
| if s.Name == "" && s.GenerateName != "" { | ||
| s.Name = fmt.Sprintf("%s-%d", s.GenerateName, mathrand.Intn(10000)) |
There was a problem hiding this comment.
This is probably good enough but may cause super weird failures if the same int is generated 2+ times.
Maybe it would be better to use a per-test generator? Would a simple counter then be sufficient to provide uniqueness?
But if you stick with rand, does it need to be Seeded?
There was a problem hiding this comment.
what if we just use the same random string function that k8s uses to generate ranm pod names? (yes there is still the theoretical chance of conflict, but if that was the only source of flakiness I think I can live with that)
There was a problem hiding this comment.
Works for me. I really just wanted to point out the potential issue in case it was likely to cause issues.
There was a problem hiding this comment.
yeah indeed 1000 was too small a number
|
travis is having an hiccup; I'm optimistic and merging this manually |
Currently the controller tests are plagued by:
which is caused by the tests creating secrets with empty Name assuming that GenerateName will issue a new name. Unfortunately the fake client doesn't honour GenerateName. According to kubernetes/client-go#439 users are supposed to implement this in their own testing code, so here we are.
I need this in order to implement the test for #299