Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cutoff time #299

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Implement cutoff time #299

merged 1 commit into from
Oct 29, 2019

Conversation

mkmik
Copy link
Collaborator

@mkmik mkmik commented Oct 28, 2019

Addresses #199

TODO:

  • some tests
  • update doc

@mkmik mkmik requested review from atomatt and jjo October 28, 2019 17:31
jjo
jjo approved these changes Oct 28, 2019
View reviewed changes
Copy link

@jjo jjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkmik
Copy link
Collaborator Author

mkmik commented Oct 29, 2019

bors r+

bors bot added a commit that referenced this pull request Oct 29, 2019
@bors
Merge #299
4981177 
299: Implement cutoff time r=mkmik a=mkmik

Addresses #199

TODO:
* some tests 
* update doc



Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@mkmik
Copy link
Collaborator Author

mkmik commented Oct 29, 2019

bors r+

bors bot added a commit that referenced this pull request Oct 29, 2019
@bors
Merge #299
877b3ad 
299: Implement cutoff time r=mkmik a=mkmik

Addresses #199

TODO:
* some tests 
* update doc



Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@mkmik mkmik added this to the v0.9.3 milestone Oct 29, 2019
@bors
Copy link
Contributor

bors bot commented Oct 29, 2019

Build succeeded

@bors bors bot merged commit 5a46e37 into master Oct 29, 2019
@bors bors bot deleted the cutoff branch October 29, 2019 14:00
This was referenced Oct 29, 2019
Closed
Merged
mkmik pushed a commit that referenced this pull request Oct 29, 2019
Test key cutoff feature from #299
8fa8352
mkmik pushed a commit that referenced this pull request Oct 29, 2019
Test key cutoff feature from #299
babef3a
bors bot added a commit that referenced this pull request Oct 29, 2019
@bors
Merge #302
5b09401 
302: Test key cutoff feature from #299 r=mkmik a=mkmik



Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjo jjo jjo approved these changes

@atomatt atomatt atomatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mkmik @atomatt @jjo