Merge #302

302: Test key cutoff feature from #299 r=mkmik a=mkmik Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
bitnami-labs · Oct 29, 2019 · 5b09401 · 5b09401
2 parents 4c05572 + babef3a
commit 5b09401
Showing 1 changed file with 45 additions and 0 deletions.
diff --git a/cmd/controller/main_test.go b/cmd/controller/main_test.go
@@ -235,6 +235,51 @@ func TestRenewStaleKey(t *testing.T) {
 	}
 }
 
+func TestKeyCutoff(t *testing.T) {
+	rand := testRand()
+	key, err := rsa.GenerateKey(rand, 512)
+	if err != nil {
+		t.Fatalf("Failed to generate test key: %v", err)
+	}
+
+	cert, err := signKey(rand, key)
+	if err != nil {
+		t.Fatalf("signKey failed: %v", err)
+	}
+
+	// we'll simulate the existence of a secret that would be still valid
+	// according to our rotation period, if it were not for it being older than the cutoff date.
+	const (
+		period = 24 * time.Hour
+		oldAge = 1 * time.Hour
+	)
+	client := fake.NewSimpleClientset()
+	client.PrependReactor("create", "secrets", generateNameReactor)
+
+	_, err = writeKey(client, key, []*x509.Certificate{cert}, "namespace", SealedSecretsKeyLabel, "prefix",
+		writeKeyWithCreationTime(metav1.NewTime(time.Now().Add(-oldAge))))
+	if err != nil {
+		t.Errorf("writeKey() failed with: %v", err)
+	}
+
+	registry, err := initKeyRegistry(client, rand, "namespace", "prefix", SealedSecretsKeyLabel, 1024)
+	if err != nil {
+		t.Fatalf("initKeyRegistry() returned err: %v", err)
+	}
+
+	client.ClearActions()
+
+	// by setting cutoff to "now" we effectively force the creation of a new key.
+	_, err = initKeyRenewal(registry, period, time.Now())
+	if err != nil {
+		t.Fatalf("initKeyRenewal() returned err: %v", err)
+	}
+
+	if !hasAction(client, "create", "secrets") {
+		t.Errorf("trigger function failed to activate early key generation")
+	}
+}
+
 func writeLegacyKey(client kubernetes.Interface, key *rsa.PrivateKey, certs []*x509.Certificate, namespace, name string) (string, error) {
 	certbytes := []byte{}
 	for _, cert := range certs {