xmpp xep-0191/blocklist #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dequis
reviewed
Apr 11, 2021
|
simplified the thing :D |
|
Still LGTM; @dequis , any objections to merging this? |
jelmer
requested changes
Feb 28, 2023
| * BitlBee - An IRC to IM gateway * | ||
| * Jabber module - Handling of blocking * | ||
| * * | ||
| * Copyright 2021 / <> * |
There was a problem hiding this comment.
This should have a proper copyright statement
There was a problem hiding this comment.
how would that look like? we just copypasted it from some other file and replaced name/mail with our git details, thought that would be fine.
There was a problem hiding this comment.
This particular line is just empty, it should have your identity as the copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jabber_data now carries a feature list which is filled at login. repeated filling does not destroy duplicates, probably not an issue for now?