Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting multiple accounts/groups/protocols to filter a control channel's buddy roster through fill_by. #137

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

zer0def
Copy link

@zer0def zer0def commented Oct 23, 2019

Recreation of #136 , but based in develop.

Allows to specify multiple comma-delimited accounts/groups/protocols in respective fields of a control channel, which when used with fill_by would allow to filter (and filter out) the buddy roster by more than a single entity of a given type.

As I'm not much of a bee_group user, I've only padded out the respective functionality for inviting and kicking users from group-based channels, so hopefully that works.

@digitalcircuit
Copy link
Contributor

Might be worthwhile updating the documentation to make note of this, too:

<bitlbee-setting name="fill_by" type="string" scope="channel">

irc_channel.c Outdated Show resolved Hide resolved
irc_channel.c Show resolved Hide resolved
irc_channel.c Outdated Show resolved Hide resolved
irc_channel.c Outdated Show resolved Hide resolved
@zer0def zer0def force-pushed the icc-fillby-multiple branch from 54bbf56 to 2e9aba2 Compare October 29, 2019 20:36
@zer0def zer0def requested a review from dequis November 2, 2019 19:40
@zer0def zer0def force-pushed the icc-fillby-multiple branch from 2e9aba2 to 9c9ad53 Compare January 12, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants