Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purple: add option to automatically mark new messages as read #131

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

eeeeeta
Copy link

@eeeeeta eeeeeta commented Jul 28, 2019

(depends on #125)

  • The new mark_read option controls whether messages are marked
    as read upon reception by bitlbee.
  • Not all libpurple prpls actually support this, but the ones that
    do (e.g. slack-libpurple) seem to be watching out for a
    conversation update of type PURPLE_CONV_UPDATE_UNSEEN, so we
    send that on message reception if the option is enabled.
  • Additionally, some (like purple-facebook) check for has_focus, so
    we always return TRUE for that if mark_read is enabled.

eeeeeta and others added 7 commits April 4, 2019 11:43
(Most of these changes are aimed at making matrix not a pain to use)
- The `defer_joins` option on prpl accounts waits for users to be added
  to a prpl conversation before adding the bitlbee user, in the hope
  of being able to get some chat name/alias metadata before doing so.
- (To that end, the name hint for rooms is now updated when users are
  added.)
- The `name_with_tag` options prefixes the account tag to the name hint
  for prpl accounts, in order to namespace prpl channels somewhat.
- The `use_matrix_alias` option is specialized for the purple-matrix
  plugin, and makes the name hint use the `matrix_alias` data item
  of the prpl conversation, instead of the title.
- The new `mark_read` option controls whether messages are marked
  as read upon reception by bitlbee.
- Not all libpurple prpls actually support this, but the ones that
  do (e.g. slack-libpurple) seem to be watching out for a
  conversation update of type PURPLE_CONV_UPDATE_UNSEEN, so we
  send that on message reception if the option is enabled.
- Additionally, some (like purple-facebook) check for has_focus, so
  we always return TRUE for that if mark_read is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant