Fix Ruby module name generation when the ruby_package option is used (p…

…rotocolbuffers#5735) * fix module name generation and add tests * fix existing tests * support both package name styles
bithium · Feb 28, 2019 · 0a1ee2b · 0a1ee2b
1 parent c371fa2
commit 0a1ee2b
Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit.proto b/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit.proto
@@ -0,0 +1,9 @@
+syntax = "proto3";
+
+package one.two.a_three;
+
+option ruby_package = "A::B::C";
+
+message Four {
+  string a_string = 1;
+}
diff --git a/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit_legacy.proto b/google/protobuf/compiler/ruby/ruby_generated_pkg_explicit_legacy.proto
@@ -0,0 +1,9 @@
+syntax = "proto3";
+
+package one.two.a_three.and;
+
+option ruby_package = "AA.BB.CC";
+
+message Four {
+  string another_string = 1;
+}
diff --git a/google/protobuf/compiler/ruby/ruby_generated_pkg_implicit.proto b/google/protobuf/compiler/ruby/ruby_generated_pkg_implicit.proto
@@ -0,0 +1,7 @@
+syntax = "proto3";
+
+package one.two.a_three;
+
+message Four {
+  string a_string = 1;
+}