Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net, init: derive default onion port if a user specified a -port #31223

Merged
merged 3 commits into from
Dec 13, 2024
Merged

net, init: derive default onion port if a user specified a -port #31223

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e2b12b
net, init: derive default onion port if a user specified a -port
mzumsande Nov 4, 2024
997757d
test: add functional test for -port behavior
mzumsande Nov 15, 2024
1dd3af8
Add release note for #31223
mzumsande Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add release note for #31223 
Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
  • Loading branch information
@mzumsande @vasild
mzumsande and vasild committed Nov 15, 2024
commit 1dd3af8fbc350c6f1efa8ae6449e67e1b42ccff4
15 changes: 15 additions & 0 deletions doc/release-notes-31223.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
P2P and network changes
-----------------------
When the `-port` configuration option is used, the default onion listening port will now
be derived to be that port + 1 instead of being set to a fixed value (8334 on mainnet).
This re-allows setups with multiple local nodes using different `-port` and not using `-bind`,
which would lead to a startup failure in v28.0 due to a port collision.

Note that a `HiddenServicePort` manually configured in `torrc` may need adjustment if used in
connection with the `-port` option.
For example, if you are using `-port=5555` with a non-standard value and not using `-bind=...=onion`,
previously Bitcoin Core would listen for incoming Tor connections on `127.0.0.1:8334`.
Now it would listen on `127.0.0.1:5556` (`-port` plus one). If you configured the hidden service manually
in torrc now you have to change it from `HiddenServicePort 8333 127.0.0.1:8334` to `HiddenServicePort 8333
127.0.0.1:5556`, or configure bitcoind with `-bind=127.0.0.1:8334=onion` to get the previous behavior.
(#31223)
Loading