-
Notifications
You must be signed in to change notification settings - Fork 36.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guix: use GCC 13 to build releases #29881
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/29881. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
For reference, the previous bump was e1ce5b8, which is in master only and not yet in a release branch. |
CI should be bumped as well, if this is taken out of draft. Just leaving a comment here, so that it isn't forgotten. |
005e3e6
to
51cf84c
Compare
Added a (WIP) commit to bump a couple CIs to 13.2.0. Also bumped the time-machine further, now that we've upstreamed GCC 13.3.0: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17. |
Looks like Windows still has false positives with GCC 13.2.0 (https://github.com/bitcoin/bitcoin/pull/29881/checks?check_run_id=25320716500): torcontrol.cpp: In static member function ‘static void TorControlConnection::readcb(bufferevent*, void*)’:
torcontrol.cpp:94:28: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]
94 | self->message.code = ToIntegral<int>(s.substr(0, 3)).value_or(0);
| ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./netaddress.h:14,
from ./torcontrol.h:11,
from torcontrol.cpp:6:
./util/strencodings.h:184:7: note: ‘result’ was declared here
184 | T result;
| ^~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:11115: libbitcoin_node_a-torcontrol.o] Error 1 Will re-add |
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
348e6c8
to
569ff3f
Compare
Includes: LLVM 18.1.x (bitcoin#30201) GCC 13.x (bitcoin#29881) Kernel Headers 6.1.80 -> 6.1.92 Commits like https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824, which should improve the bootstrap situation (bitcoin#30042).
Includes: LLVM 18.1.x (bitcoin#30201) GCC 13.x (bitcoin#29881) Kernel Headers 6.1.80 -> 6.1.92 Commits like https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824, which should improve the bootstrap situation (bitcoin#30042).
Includes: LLVM 18.1.x (bitcoin#30201) GCC 13.x (bitcoin#29881) git-minimal 2.41.0 -> 2.45.1 Kernel Headers 6.1.80 -> 6.1.92 moreutils 0.68 -> 0.69 Commits like https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824, which should improve the bootstrap situation (bitcoin#30042).
Guix builds (aarch64):
|
Guix Build (x86_64): a22efc082966018f6ddd17d1a7092ffda56900895dd4694080244257e1c5c974 guix-build-6f0513613a98/output/aarch64-linux-gnu/SHA256SUMS.part
ad65ac733f93931c5fcfa09afc2a1f8bed76cd5280be9b569ff9bdf15dec3abe guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu-debug.tar.gz
abc9037335e719927525c0474a7959db57a6f3f64d9522474ede4d88e721f73c guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu.tar.gz
fdb01866f033273d588340e533840ecfd3d9ed51d91676b3324de3c7a26d114e guix-build-6f0513613a98/output/arm-linux-gnueabihf/SHA256SUMS.part
5873b129b2cf9efc36770a25c7f2315c491368cf30a61ee3677ec6283d64507d guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf-debug.tar.gz
eca5831c1cc9e8894fc1b2576530f49e55f02e28e4a5b18712fbe5390c5c2894 guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf.tar.gz
82d1d8a1dd594fe1ac74a9bef6b95b29b9072c9b97170eb415d079d2b23df0dd guix-build-6f0513613a98/output/arm64-apple-darwin/SHA256SUMS.part
87701bec7a281857660cec63f53c5eec2bc1aca613fbc915dbff0832f6fcc048 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.tar.gz
0061861b901390bcd35998f50a4aebc72cbe0e0d0ba0d6e5a723c25e0df60bd2 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.zip
ee4fb897f7b1edce434b49e33f2d57e8c19609616a2de81b69af7dbe4d3345d1 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin.tar.gz
dd84d6066534402a58247e810214f88488c7d8b63a5c10a70dff63e7b283318c guix-build-6f0513613a98/output/dist-archive/bitcoin-6f0513613a98.tar.gz
1b3e385809dcb62aa07d8ccbe6320f9f3c3da97c2ab3d53cc5f0b29930fa57bf guix-build-6f0513613a98/output/powerpc64-linux-gnu/SHA256SUMS.part
384e0727561e6e26dad72c5921b69b7f3ec2318668d7aa6e73a5075cb31c1225 guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu-debug.tar.gz
4b2d077c2901c704bfff704def1ed4dd11b221bfc8fc2a3577e9f63b3dd32e27 guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu.tar.gz
83b1d34c4189530cea18aaa89f55628c9df23bbf9abe6ecf3fd9f62abcff1df4 guix-build-6f0513613a98/output/riscv64-linux-gnu/SHA256SUMS.part
54bfb1ef49ae9567d3f79a8c959ce1580b4cd4add47a7611992d37fa9c3dd84c guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu-debug.tar.gz
19cea2c3cda1374bb6c969df706d344c91737a061cc23e997bec1368c1af2420 guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu.tar.gz
a4defa1c1c3948c134705cd3c25a96a4e98a6c5b884c5eebb1948f1b7af7e865 guix-build-6f0513613a98/output/x86_64-apple-darwin/SHA256SUMS.part
0b745d24fa17ecaeb85404c3e6335f96e0cd975668d6c0f6ce2f4fd75c68b5aa guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.tar.gz
049f56eccc19ac292ebc2df00ee18cc063cde109306ab2dba716c3f2bf5bfaf0 guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.zip
20784bac737e7b9da1fb9743ad76dd4e0d4659743e4ae857f40ab4c551843571 guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin.tar.gz
3f799bfc0ca76314873508b95f3a577c2b48eed4bf3509d14b9945809c241c4b guix-build-6f0513613a98/output/x86_64-linux-gnu/SHA256SUMS.part
843dcd76b6c0b3eb5f252603969a973ef6668b02473f06ebe55a19642e203d6f guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu-debug.tar.gz
2f2aa78458c679b7233b2201f4e4604e08a705b1eed9731f67a9128f15088c5c guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu.tar.gz
d658030334948903847a56f3ab2058219aaf04f65126af92075551ea7c3055d0 guix-build-6f0513613a98/output/x86_64-w64-mingw32/SHA256SUMS.part
4270d8383256376b8d751203baa6c57f83bda3d1868cfa0aa9ea87fd0684b95c guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-debug.zip
403150548e9fe249b035ef2641a8d1faad22d881561092b0c232d4779439a130 guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-setup-unsigned.exe
7195be67f54f369923deb56bc07682f64b3cd68eeb986085e0e2cb9542bf6d1f guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-unsigned.tar.gz
86809fdb4d014e57b3137b1db9889ed68c73cce1e04f1ec837f0a121fd9315c6 guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64.zip |
My Guix build:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6f05136
Guix build (aarch64):
a22efc082966018f6ddd17d1a7092ffda56900895dd4694080244257e1c5c974 guix-build-6f0513613a98/output/aarch64-linux-gnu/SHA256SUMS.part
ad65ac733f93931c5fcfa09afc2a1f8bed76cd5280be9b569ff9bdf15dec3abe guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu-debug.tar.gz
abc9037335e719927525c0474a7959db57a6f3f64d9522474ede4d88e721f73c guix-build-6f0513613a98/output/aarch64-linux-gnu/bitcoin-6f0513613a98-aarch64-linux-gnu.tar.gz
fdb01866f033273d588340e533840ecfd3d9ed51d91676b3324de3c7a26d114e guix-build-6f0513613a98/output/arm-linux-gnueabihf/SHA256SUMS.part
5873b129b2cf9efc36770a25c7f2315c491368cf30a61ee3677ec6283d64507d guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf-debug.tar.gz
eca5831c1cc9e8894fc1b2576530f49e55f02e28e4a5b18712fbe5390c5c2894 guix-build-6f0513613a98/output/arm-linux-gnueabihf/bitcoin-6f0513613a98-arm-linux-gnueabihf.tar.gz
82d1d8a1dd594fe1ac74a9bef6b95b29b9072c9b97170eb415d079d2b23df0dd guix-build-6f0513613a98/output/arm64-apple-darwin/SHA256SUMS.part
87701bec7a281857660cec63f53c5eec2bc1aca613fbc915dbff0832f6fcc048 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.tar.gz
0061861b901390bcd35998f50a4aebc72cbe0e0d0ba0d6e5a723c25e0df60bd2 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin-unsigned.zip
ee4fb897f7b1edce434b49e33f2d57e8c19609616a2de81b69af7dbe4d3345d1 guix-build-6f0513613a98/output/arm64-apple-darwin/bitcoin-6f0513613a98-arm64-apple-darwin.tar.gz
dd84d6066534402a58247e810214f88488c7d8b63a5c10a70dff63e7b283318c guix-build-6f0513613a98/output/dist-archive/bitcoin-6f0513613a98.tar.gz
1b3e385809dcb62aa07d8ccbe6320f9f3c3da97c2ab3d53cc5f0b29930fa57bf guix-build-6f0513613a98/output/powerpc64-linux-gnu/SHA256SUMS.part
384e0727561e6e26dad72c5921b69b7f3ec2318668d7aa6e73a5075cb31c1225 guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu-debug.tar.gz
4b2d077c2901c704bfff704def1ed4dd11b221bfc8fc2a3577e9f63b3dd32e27 guix-build-6f0513613a98/output/powerpc64-linux-gnu/bitcoin-6f0513613a98-powerpc64-linux-gnu.tar.gz
83b1d34c4189530cea18aaa89f55628c9df23bbf9abe6ecf3fd9f62abcff1df4 guix-build-6f0513613a98/output/riscv64-linux-gnu/SHA256SUMS.part
54bfb1ef49ae9567d3f79a8c959ce1580b4cd4add47a7611992d37fa9c3dd84c guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu-debug.tar.gz
19cea2c3cda1374bb6c969df706d344c91737a061cc23e997bec1368c1af2420 guix-build-6f0513613a98/output/riscv64-linux-gnu/bitcoin-6f0513613a98-riscv64-linux-gnu.tar.gz
a4defa1c1c3948c134705cd3c25a96a4e98a6c5b884c5eebb1948f1b7af7e865 guix-build-6f0513613a98/output/x86_64-apple-darwin/SHA256SUMS.part
0b745d24fa17ecaeb85404c3e6335f96e0cd975668d6c0f6ce2f4fd75c68b5aa guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.tar.gz
049f56eccc19ac292ebc2df00ee18cc063cde109306ab2dba716c3f2bf5bfaf0 guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin-unsigned.zip
20784bac737e7b9da1fb9743ad76dd4e0d4659743e4ae857f40ab4c551843571 guix-build-6f0513613a98/output/x86_64-apple-darwin/bitcoin-6f0513613a98-x86_64-apple-darwin.tar.gz
3f799bfc0ca76314873508b95f3a577c2b48eed4bf3509d14b9945809c241c4b guix-build-6f0513613a98/output/x86_64-linux-gnu/SHA256SUMS.part
843dcd76b6c0b3eb5f252603969a973ef6668b02473f06ebe55a19642e203d6f guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu-debug.tar.gz
2f2aa78458c679b7233b2201f4e4604e08a705b1eed9731f67a9128f15088c5c guix-build-6f0513613a98/output/x86_64-linux-gnu/bitcoin-6f0513613a98-x86_64-linux-gnu.tar.gz
d658030334948903847a56f3ab2058219aaf04f65126af92075551ea7c3055d0 guix-build-6f0513613a98/output/x86_64-w64-mingw32/SHA256SUMS.part
4270d8383256376b8d751203baa6c57f83bda3d1868cfa0aa9ea87fd0684b95c guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-debug.zip
403150548e9fe249b035ef2641a8d1faad22d881561092b0c232d4779439a130 guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-setup-unsigned.exe
7195be67f54f369923deb56bc07682f64b3cd68eeb986085e0e2cb9542bf6d1f guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64-unsigned.tar.gz
86809fdb4d014e57b3137b1db9889ed68c73cce1e04f1ec837f0a121fd9315c6 guix-build-6f0513613a98/output/x86_64-w64-mingw32/bitcoin-6f0513613a98-win64.zip
8fd60e2
to
87973e5
Compare
Changed the CI changes here, the win64 job is now |
ci/test/00_setup_env_win64.sh
Outdated
@@ -7,7 +7,7 @@ | |||
export LC_ALL=C.UTF-8 | |||
|
|||
export CONTAINER_NAME=ci_win64 | |||
export CI_IMAGE_NAME_TAG="docker.io/debian:bookworm" # Check that https://packages.debian.org/bookworm/g++-mingw-w64-x86-64-posix (version 12.2, similar to guix) can cross-compile | |||
export CI_IMAGE_NAME_TAG="docker.io/debian:trixie" # Check that https://packages.debian.org/trixie/g++-mingw-w64-x86-64-posix (version 13.3, similar to guix) can cross-compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any insurance that debian won't bump this to gcc 14 as well? Seems better to stick to 13.2, than to silently go to 14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking this might also be needed if we want to test the newer runtime in future, but given that isn't happening yet, will just return this to nobel
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guix build (aarch64):
b381ff87a34e45f693abee5554dd0680cb7879d66787f8aba45fb9dd149e8e78 guix-build-0c1b29a05777/output/aarch64-linux-gnu/SHA256SUMS.part
d3cb534b26ee5edd0c5d459cfffd3ebb46235da21ce2c614fda92d56f4b6ba98 guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu-debug.tar.gz
b6b73fe6c3ae291e4c3d702a1343e44f3c143b50a566f1a0412dbfcf45fe31e2 guix-build-0c1b29a05777/output/aarch64-linux-gnu/bitcoin-0c1b29a05777-aarch64-linux-gnu.tar.gz
1aa98bef1d9a741e9b3e0bd306100d9fb12177267b30be23577693142710b6f6 guix-build-0c1b29a05777/output/arm-linux-gnueabihf/SHA256SUMS.part
208130deecd603ee5fa1f6dbc252a3fd5aa8498920adb94384062a45bbfcb2b6 guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf-debug.tar.gz
90e0d50c0adf998bf24a54d7280f3af745f33fa4037e1b5584e162cf0677270f guix-build-0c1b29a05777/output/arm-linux-gnueabihf/bitcoin-0c1b29a05777-arm-linux-gnueabihf.tar.gz
3b3887c421ae1beb8f524f56355713e09dc683cc8a801006b843d7380bfa5d48 guix-build-0c1b29a05777/output/arm64-apple-darwin/SHA256SUMS.part
1f25ea8cc64c179e68aaaadfae3cb408a790a230108f11974ab7f70359d6836a guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.tar.gz
1310af4f7e1f72100dd3e56a79ea935e712df3735e4129dbd4d905b659f4d5ad guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin-unsigned.zip
94165e88c22654a1e8a27070164842231901403f34b5326649ae645ab70e96d9 guix-build-0c1b29a05777/output/arm64-apple-darwin/bitcoin-0c1b29a05777-arm64-apple-darwin.tar.gz
5991b11d616c3abd2f78c2476259f103ea1a940cc77281c9d029da8f99b74906 guix-build-0c1b29a05777/output/dist-archive/bitcoin-0c1b29a05777.tar.gz
2f7c78cc66a41f94f2c6dd42caf952055b5cd5d20b2c6d93cab83a1855a103a0 guix-build-0c1b29a05777/output/powerpc64-linux-gnu/SHA256SUMS.part
38bb7a02041967e4dfb76748899c0565695a078bd112a8656fb1268365355109 guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu-debug.tar.gz
00a8a44de3038a36174cfd8067bf39ad24962efa2cea216022cbb4e289adbcc7 guix-build-0c1b29a05777/output/powerpc64-linux-gnu/bitcoin-0c1b29a05777-powerpc64-linux-gnu.tar.gz
5f485a4ba475268b7172e215750569843e484835b98be7e2c2ed7543886c668d guix-build-0c1b29a05777/output/riscv64-linux-gnu/SHA256SUMS.part
dd8c40507ebe0a94acfe8860278234b7687d312939938b9c5ed49667d2e74339 guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu-debug.tar.gz
87151f838ccd918e28dd2fdb4729a150ad72f1c3f72f49c46fa9da4b30f2efdb guix-build-0c1b29a05777/output/riscv64-linux-gnu/bitcoin-0c1b29a05777-riscv64-linux-gnu.tar.gz
b237b88534fab0314d652b66514053af3b18ba798fac353a3a0a5482ee07cf7c guix-build-0c1b29a05777/output/x86_64-apple-darwin/SHA256SUMS.part
ded3d046f842a6d532c45dfb465e23e23c2c94f8f58e0047aaa5d0a7ffbadd65 guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.tar.gz
5da4593213c0b9eac24b8e8eb2faa536899a1f9dec64aae2189e7507a844a2a3 guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin-unsigned.zip
96e998f7ee34bafabe7273e12412045d9227a96dc4b37dba8a25969a3b6856bc guix-build-0c1b29a05777/output/x86_64-apple-darwin/bitcoin-0c1b29a05777-x86_64-apple-darwin.tar.gz
63eef56512820eb91cb961212ec55b8994afcfe9526dbb25d9bae9b244339496 guix-build-0c1b29a05777/output/x86_64-linux-gnu/SHA256SUMS.part
d0bd954da5c64064745c1bde9e8462b0ebb05787801b4b1fd7087f0a0d4c1870 guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu-debug.tar.gz
2536953874c70adb5c9a3dd7a14229c96533ee00465c212d0271f43a173608ec guix-build-0c1b29a05777/output/x86_64-linux-gnu/bitcoin-0c1b29a05777-x86_64-linux-gnu.tar.gz
31bdd0d8012adcb017fb23805a788e724ea437854463cd96f97b75eb2382f6be guix-build-0c1b29a05777/output/x86_64-w64-mingw32/SHA256SUMS.part
2712d61c07ab7c7298244dc83d870c7e934055d20581ae0a1ae45eccb3db3842 guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-debug.zip
59cc8134cb597f9c8075eb1a8e3b13a95f60bbd452bbe0b67baf933034f54c25 guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-setup-unsigned.exe
c6527bca15c54d0e18aa392f5a3609844d53772604508ccd3dffe6730aab8700 guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64-unsigned.tar.gz
786f68ee33e8d075be0d2e1cccd05ebf64d196ba5d7eb3e429ab8581f41c0a6a guix-build-0c1b29a05777/output/x86_64-w64-mingw32/bitcoin-0c1b29a05777-win64.zip
My Guix build:
|
@@ -7,7 +7,7 @@ | |||
export LC_ALL=C.UTF-8 | |||
|
|||
export CONTAINER_NAME=ci_win64 | |||
export CI_IMAGE_NAME_TAG="docker.io/debian:bookworm" # Check that https://packages.debian.org/bookworm/g++-mingw-w64-x86-64-posix (version 12.2, similar to guix) can cross-compile | |||
export CI_IMAGE_NAME_TAG="docker.io/ubuntu:noble" # Check that g++-mingw-w64-x86-64-posix (version 13.2, similar to guix) can cross-compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Why not keep a full URL, as in other places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0c1b29a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-ACK 0c1b29a
ACK 0c1b29a
|
Switch release builds to using GCC 13.3.0: https://gcc.gnu.org/gcc-13/, which landed in Guix in: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17.
Does not solve the cross-arch non-determinism for
powerpc64le-linux-gnu
builds.