Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve thread safety analysis by propagating some negative capabilities #25175

Merged
merged 2 commits into from
May 20, 2022
Merged

refactor: Improve thread safety analysis by propagating some negative capabilities #25175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a6e3c1
refactor: Propagate negative `!m_most_recent_block_mutex` capability
hebasto May 20, 2022
2b3373c
refactor: Propagate negative `!m_tx_relay_mutex` capability
hebasto May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: Propagate negative !m_tx_relay_mutex capability 
Could be verified with
$ ./configure CC=clang CXX=clang++ CXXFLAGS='-Wthread-safety -Wthread-safety-negative'
$ make clean
$ make 2>&1 | grep m_tx_relay_mutex
  • Loading branch information
@hebasto
hebasto committed May 20, 2022
commit 2b3373c1520aa0b41277cd89956224e08cbd79dd
2 changes: 1 addition & 1 deletion src/net_processing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ struct Peer {
};

/* Initializes a TxRelay struct for this peer. Can be called at most once for a peer. */
TxRelay* SetTxRelay()
TxRelay* SetTxRelay() EXCLUSIVE_LOCKS_REQUIRED(!m_tx_relay_mutex)
{
LOCK(m_tx_relay_mutex);
Assume(!m_tx_relay);
Expand Down