Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, qt: Fix make deploy on M1-based macOS with system frameworks #22546

Merged
merged 2 commits into from
Feb 23, 2022
Merged

build, qt: Fix make deploy on M1-based macOS with system frameworks #22546

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26a0a5
build, qt: Align frameworks with macOS codesign tool requirements
hebasto Jul 25, 2021
1513727
build, qt: (Re-)sign package
hebasto Jul 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build, qt: (Re-)sign package 
Starting with macOS 11 on Apple silicon, executables must be signed
before they are allowed to run.
  • Loading branch information
@hebasto
hebasto committed Feb 17, 2022
commit 1513727e2b38800c694d1204cb454cc6fabc4937
5 changes: 4 additions & 1 deletion contrib/macdeploy/macdeployqtplus
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#

import sys, re, os, shutil, stat, os.path
import sys, re, os, platform, shutil, stat, subprocess, os.path
from argparse import ArgumentParser
from ds_store import DSStore
from mac_alias import Alias
Expand Down Expand Up @@ -541,6 +541,9 @@ ds.close()

# ------------------------------------------------

if platform.system() == "Darwin":
subprocess.check_call(f"codesign --deep --force --sign - {target}", shell=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone else's reference, passing - to --sign invokes ad-hoc signing, which is more limited in it's capabilities, but sufficient for locally running/testing binaries.

If identity is the single letter "-" (dash), ad-hoc signing is performed. Ad-hoc signing does not use an identity at all, and identifies exactly one instance of code. Significant restrictions apply to the use of ad-hoc signed code; consult documentation before using this.


if config.dmg is not None:

print("+ Preparing .dmg disk image +")
Expand Down