Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve rpc_blockchain.py tests and assert on time and mediantime #22520

Merged
merged 4 commits into from
Jul 30, 2021
Merged

test: improve rpc_blockchain.py tests and assert on time and mediantime #22520

merged 4 commits into from
Jul 30, 2021

Conversation

jonatack
Copy link
Member

Follow-up to #22407 improving test coverage per #22407 (review).

@DrahtBot DrahtBot added the Tests label Jul 21, 2021
@jonatack jonatack force-pushed the getblockchaininfo-time-tests branch from 03c80e2 to dd476e7 Compare July 21, 2021 16:19
@jonatack jonatack changed the title test: assert on the values of getblockchaininfo time/mediantime test: improve rpc_blockchain.py tests and assert on time and mediantime Jul 21, 2021
@jonatack jonatack force-pushed the getblockchaininfo-time-tests branch from dd476e7 to ef5e930 Compare July 22, 2021 00:52
@jonatack
Copy link
Member Author

Updated per git diff dd476e7 ef5e930 for a few more changes to be made in the third commit, "test: replace magic values by constants in rpc_blockchain.py."

@DrahtBot DrahtBot mentioned this pull request Jul 28, 2021
Closed
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@tryphe
Copy link
Contributor

tryphe commented Jul 30, 2021

untested ACK ef5e930

Test is more robust and the documentation of which RPCs are tested is corrected. I say we wait until #22567 is merged first though :)

@maflcko maflcko merged commit b6c3fce into bitcoin:master Jul 30, 2021
@jonatack jonatack deleted the getblockchaininfo-time-tests branch July 30, 2021 09:58
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 1, 2021
Merge bitcoin#22520: test: improve rpc_blockchain.py tests and assert…
111592e 
… on tim…
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RandyMcMillan RandyMcMillan RandyMcMillan left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonatack @DrahtBot @tryphe @RandyMcMillan @maflcko