Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macdeploy: alternative info to download the macOS SDK #22516

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

darosior
Copy link
Member

The previous link wasn't accessible for me, this adds some instructions
given to me by Hebasto on #bitcoin-core-builds as well as a shasum for
the archive to quickly check the downloaded one is the right one before
processing with the entire Guix build.

@fanquake fanquake added the Docs label Jul 21, 2021
@hebasto
Copy link
Member

hebasto commented Jul 21, 2021

Concept ACK.

It seems https://developer.apple.com just requires that one is logged in before following the https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip link.

@Emzy
Copy link
Contributor

Emzy commented Jul 21, 2021

Concept ACK.
I always get a "403 Forbidden", also after being logged in.
Searching for "12.1" on https://developer.apple.com/download/all/ works.
I checked the sha256sum of my Xcode_12.1.xip file and got a match. 612443b1894b39368a596ea1607f30cbb0481ad44d5e29c75edb71a6d2cf050f

@hebasto
Copy link
Member

hebasto commented Jul 21, 2021

While touching this file, maybe update these lines as well

To complicate things further, all builds must target an Apple SDK. These SDKs are free to
download, but not redistributable. To obtain it, register for an Apple Developer Account,
then download [Xcode_11.3.1](https://download.developer.apple.com/Developer_Tools/Xcode_11.3.1/Xcode_11.3.1.xip).
?

Or just drop them?

@achow101
Copy link
Member

I think it would be useful to mention that cookies for https://download.developer.apple.com/ need to be allowed in order for the actual download link to work. Otherwise you could still login and click the download link and still get a 403.

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

It's a bit tricky to accurately convey my suggestions using the online github tools, so below is a diff and here is a branch with my suggestions:

diff --git a/contrib/macdeploy/README.md b/contrib/macdeploy/README.md
index ad52f7d20..6b8de576e 100644
--- a/contrib/macdeploy/README.md
+++ b/contrib/macdeploy/README.md
@@ -15,10 +15,11 @@ When complete, it will have produced `Bitcoin-Core.dmg`.
 Our current macOS SDK
 (`Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers.tar.gz`) can be
 extracted from
-[Xcode_12.1.xip](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip)
-(alternatively, after login to your account go to "Downloads", then "More" and look for [`Xcode_12.1`](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip)).
-An Apple ID is needed to download this.
-The `sha256sum` of the archive should be `612443b1894b39368a596ea1607f30cbb0481ad44d5e29c75edb71a6d2cf050f`.
+[Xcode_12.1.xip](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip). An Apple ID is needed to download this.
+
+Alternatively, after logging in to your Apple Developer account, go to 'Downloads' -> 'More' and look for [`Xcode_12.1`](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip).
+
+The `sha256sum` of the SDK archive file should be `612443b1894b39368a596ea1607f30cbb0481ad44d5e29c75edb71a6d2cf050f`.
 
 After Xcode version 7.x, Apple started shipping the `Xcode.app` in a `.xip`
 archive. This makes the SDK less-trivial to extract on non-macOS machines. One

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@darosior
Copy link
Member Author

While touching this file, maybe update these lines as well
Or just drop them?

As mentioned afterward by Achow the link isn't dead, but needs cookies to be enabled. Edited to reflect that.

I think it would be useful to mention that cookies for https://download.developer.apple.com/ need to be allowed in order for the actual download link to work. Otherwise you could still login and click the download link and still get a 403.

Done.

so below is a diff and here is a branch with my suggestions

Thanks, took part of it for the english and formatting part.

Diff:

diff --git a/contrib/macdeploy/README.md b/contrib/macdeploy/README.md
index ad52f7d20e..cdf2b6609f 100644
--- a/contrib/macdeploy/README.md
+++ b/contrib/macdeploy/README.md
@@ -15,8 +15,10 @@ When complete, it will have produced `Bitcoin-Core.dmg`.
 Our current macOS SDK
 (`Xcode-12.1-12A7403-extracted-SDK-with-libcxx-headers.tar.gz`) can be
 extracted from
-[Xcode_12.1.xip](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip)
-(alternatively, after login to your account go to "Downloads", then "More" and look for [`Xcode_12.1`](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip)).
+[Xcode_12.1.xip](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip).
+Cookies must be enabled for this link to work after logging in.
+Alternatively, after logging in to your account go to 'Downloads', then 'More'
+and look for [`Xcode_12.1`](https://download.developer.apple.com/Developer_Tools/Xcode_12.1/Xcode_12.1.xip).
 An Apple ID is needed to download this.
 The `sha256sum` of the archive should be `612443b1894b39368a596ea1607f30cbb0481ad44d5e29c75edb71a6d2cf050f`.

@hebasto
Copy link
Member

hebasto commented Jul 22, 2021

While touching this file, maybe update these lines as well
Or just drop them?

As mentioned afterward by Achow the link isn't dead, but needs cookies to be enabled. Edited to reflect that.

Another link points at Xcode_11.3.1 but we use Xcode_12.1 for now.

@fanquake
Copy link
Member

Do we really need to link to the same xip from 3 different places in this README? Given that half the time the links don't even seem to work (they don't work for me now even when logged in), why not just remove them, or just have one.

As mentioned above, can you also update the instance of Xcode_11.3.1 further down, and remove the link there as well. There is some duplication of information in this file, but that doesn't have to be fixed here.

The previous link wasn't accessible for me, this adds some instructions
given to me by Hebasto on #bitcoin-core-builds as well as a shasum for
the archive to quickly check the downloaded one is the right one before
processing with the entire Guix build.

This also corrects a link to an older version of the SDK currently in
use.

Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
@darosior
Copy link
Member Author

Do we really need to link to the same xip from 3 different places in this README?

No, i don't think so. I figured adding another link was helpful since it's what worked for me but i definitely don't have any opinion on how to rework this doc. This PR was just meant as a quick tiny link fix as i got through the process..

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f8f772d

@fanquake fanquake merged commit 19434fa into bitcoin:master Jul 29, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 29, 2021
…S SDK

f8f772d macdeploy: alternative info to download the macOS SDK (Antoine Poinsot)

Pull request description:

  The previous link wasn't accessible for me, this adds some instructions
  given to me by Hebasto on #bitcoin-core-builds as well as a shasum for
  the archive to quickly check the downloaded one is the right one before
  processing with the entire Guix build.

ACKs for top commit:
  fanquake:
    ACK f8f772d

Tree-SHA512: 620160b593ed8fa4ae4a748b8e72d67b93ff0ec9e6b8ef3c3ac5402c1c48ec0ac325a527b6278cdf84aaf51ba8194d4c366c412ffad141d0412add2710efcff5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 13, 2022
…S SDK

f8f772d macdeploy: alternative info to download the macOS SDK (Antoine Poinsot)

Pull request description:

  The previous link wasn't accessible for me, this adds some instructions
  given to me by Hebasto on #bitcoin-core-builds as well as a shasum for
  the archive to quickly check the downloaded one is the right one before
  processing with the entire Guix build.

ACKs for top commit:
  fanquake:
    ACK f8f772d

Tree-SHA512: 620160b593ed8fa4ae4a748b8e72d67b93ff0ec9e6b8ef3c3ac5402c1c48ec0ac325a527b6278cdf84aaf51ba8194d4c366c412ffad141d0412add2710efcff5
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants