Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test improvements for UTXO set hash tests #21390

Merged
merged 3 commits into from
Mar 26, 2021
Merged

test: Test improvements for UTXO set hash tests #21390

merged 3 commits into from
Mar 26, 2021

Conversation

fjahr
Copy link
Contributor

@fjahr fjahr commented Mar 8, 2021

Follow-ups to #19145:

  • Small improvement on the help text of RPC gettxoutsetinfo
  • Using deterministic blockchain in the test functional/feature_utxo_set_hash.py
  • Removing wallet dependency in the test functional/feature_utxo_set_hash.py

Split out of #19521.

@fjahr fjahr mentioned this pull request Mar 8, 2021
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 9, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Mar 9, 2021
Closed
@brunoerg
Copy link
Contributor

brunoerg commented Mar 9, 2021

tACK 7a1af90
MacOS 11.1

Screen Shot 2021-03-09 at 10 07 18

leonardojobim
leonardojobim approved these changes Mar 10, 2021
View reviewed changes
Copy link

@leonardojobim leonardojobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK f33a9f7 on Ubuntu 20.04.

image

@jonatack
Copy link
Member

Concept ACK. Revewing and testing #19521, then reviewing this patch.

maflcko
maflcko approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ACK d7a679302401395501840cfdf8645e41c59189ec 🚸

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK d7a679302401395501840cfdf8645e41c59189ec 🚸
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgNbgv/U5gjZHfU+bFqnoYuakKR67EJNZHxltGhQOtAh/LrftPjc4oTmh3z4qQl
EvcqZlPAUzevvCU1RpxZKeMgnjpktj67Z4nGwRV8i6YqETYja53zr51e6a4RDZRs
1MxsWEloP9kHfv0bj9M8tEQ+EB3C0122hMdY0qTH1RheWyXct8ID2u6vYLJFmOV8
qRhQKwyaCfswbCsb2PZiFVr/jXv1bwy3QzTNUTe/47m899AjRjZVeqEy8KncBVQD
Ggu7DD7hGgQW5lOkZhkBP8TCF7SwERsL0xTKlFC9jRpZ9HwWOGvQ2CYoV/NCXfOl
IxEQTnEo4Wws/qgsZQWuvPja8Qysm7Ypll44rpeHBQIiUYHh2UqHUPfPWv/6UcjQ
bQx5BEVblViGk7OqDRxxWxusnZJOfDKW8+blWIs2cNrmd4Tc+DxN2e0wM+/W8XAr
joBBJP7s9028P6c6J1Wf5KPfoBT0rmtHoH9UO60Jq9BoF5k8ht12KEswXyOKR0Xs
WyZ4OyB0
=3TUk
-----END PGP SIGNATURE-----

Timestamp of file with hash 77191ae7c24a373f7b4fa14a63f9a8762f9c8c844c6f84b706a595b934dc11c2 -

src/node/coinstats.cpp Outdated Show resolved Hide resolved
test/functional/feature_utxo_set_hash.py Outdated Show resolved Hide resolved
@maflcko
Copy link
Member

maflcko commented Mar 23, 2021

fun fact: This has three "ACKs", but only one is mentioning the correct commit hash.

@maflcko
Copy link
Member

maflcko commented Mar 23, 2021

review ACK f33a9f7 🔰

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK f33a9f7a7648c7af6fdc9a1549ab648c7498e45b 🔰
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUhlBgv/WA4HWKOJGB2xXvyc2+rgEFouD7yssPmdp7cvyqntVuKHCfhYr7V+WxUC
hqoEA88KLF5GQx2Lt1+7Rv8TU3UQTSCKmzPvypr/81VWripr8uh8VpHYMAEqh2hd
X2PKUeZEspkWodr0CrFy0K3QFU1WoiGJvOl6hfPEmzXboQrvrh93b3uh4EygRvhm
WJSd5NmCDPE5mAWVuqSHCyqI+9ZVUPFcz9w0umrht3LYGQkg2nPjHogowLs8xtzS
KThB32l4VgyE8hxpAYK4DjcC6EwfXe0XuxqVdIlZEj4EurgGYgcLlrzBq19wuoXh
bQm2FlerMT8RR0dr92TOC+zuIkNMpmZrgQ37MCMyOPtleqfZLTncYj0fnpKkPksY
Xf3Ngk6iFa3ySEnZw6CR/3mUeo8MAHvDDref7jYw9USrlaz9rCcIvzNJho3SUY/r
BnCy1PujaWg6pDuq8etDmluZkinX0fNeB0KPLPhGV/JUmsJ0magZHjTRi8Fjrdqf
1PwPRR2R
=ndTs
-----END PGP SIGNATURE-----

Timestamp of file with hash 4a2e7bb742ec362fb28376a4b87efe766247e29a659fb64940354a2212c8b214 -

@fjahr
Copy link
Contributor Author

fjahr commented Mar 23, 2021

Took @MarcoFalke 's suggestions

@maflcko
Copy link
Member

maflcko commented Mar 24, 2021

review ACK 4f2653a 👲

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK 4f2653a89018fa4d24bd2a551832a7410b682600 👲
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUj6Vgv9E2pJl5otpsc5E3bFAPvBcLt0uXlvWUouIDIko9KH46ueeURuanPHo0ON
460JbDk75RNcH1xMGhp/JlXVaTH+N9HBtKtJFooZECfr42RSM+X/LHYpJ4gyPDSN
aPuDxi71fhz3H+R+5RbHwqBvKPUEA4EuKPtbTmOL4bS9fyBUQ04N1JQfGkuSsCjK
1msR3kEfr5LaNQvqBrDrH1DSC0JleQyeqixpwelYuXlLbrXMwAGG+yp34/Bc6cJr
sZaSi1RJ2Gv5uAv5UyoZ3pGAuGX8F3a58pqzRoBUKei3EgIE1ZlNN+cDP27CQtrE
U6BFX1p6lNnHfZNtI7KPKzxH3dWxP5UFSFxJ8nksH8iRRnIfvUqY0H3HpQ61PKsx
PbIfdq8fVTJxMi22Hc4gqPiVAJzsOZdu9XmpUsDSyhJXJ3cQ+5JRY36i053PlNOL
AFkHohFjeowx8jBTxWWNxNeGqrkAg9EygZe8xG9DeTFeYM5g/0lQlO2ZdPi/YQHM
PkQJKw53
=14N0
-----END PGP SIGNATURE-----

Timestamp of file with hash ce3e75ebeace1e189987faeb3cfec5408339b7c7faa321bac4f4435d1dd5e06c -

@maflcko maflcko merged commit 9b48b3a into bitcoin:master Mar 26, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 26, 2021
Merge bitcoin#21390: test: Test improvements for UTXO set hash tests
a571a3e
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leonardojobim leonardojobim leonardojobim approved these changes

@maflcko maflcko maflcko approved these changes

Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fjahr @DrahtBot @brunoerg @jonatack @maflcko @leonardojobim