Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Corrected Typos in Documentation #20836

Closed
wants to merge 2 commits into from
Closed

doc: Corrected Typos in Documentation #20836

wants to merge 2 commits into from

Conversation

ppyordanov
Copy link
Contributor

@ppyordanov ppyordanov commented Jan 3, 2021 •
edited
Loading

Scanned the whole source code for typing errors and corrected. Added a translation correction.

If you're going to fix typos, can you please fix all of them as seen in the spelling linter script test/lint/lint-spelling.sh, e.g. I believe:

src/core_read.cpp:131: presense ==> presence
src/net_processing.h:68: anounce ==> announce
src/netaddress.h:486: compatiblity ==> compatibility
src/wallet/walletdb.cpp:429: Crypted ==> Encrypted
src/test/validation_tests.cpp:78: excercise ==> exercise
test/functional/feature_nulldummy.py:63: unnecssary ==> unnecessary

and update test/lint/lint-spelling.ignore-words.txt to ignore all of the current false positives.

@fanquake
Copy link
Member

fanquake commented Jan 3, 2021

Don't modify upstream files, generated files, historical release notes, subtrees or any translations. Remove any @ mentions from the PR body.

@michaelfolkson
Copy link
Contributor

Note also there is already this PR in progress of review. #20762

There may well be some to-dos for a follow up PR though.

@jonatack
Copy link
Member

jonatack commented Jan 3, 2021

Concept ACK for any remaining ones after doing #20836 (comment) and #20762 -- looks like you found some.

@michaelfolkson
Copy link
Contributor

Noisy labels too. A maintainer needs to reduce the Labels to just Docs

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 3, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Jan 3, 2021
Merged
@hebasto
Copy link
Member

hebasto commented Jan 3, 2021

Linter job failed: https://cirrus-ci.com/task/6073276860465152

@ppyordanov ppyordanov closed this Jan 3, 2021
@ppyordanov
doc: Addressing review comments, excluded:
6d0bc5e 
generated files
historical release notes
subtrees
translations.
@ppyordanov
Copy link
Contributor Author

Addressing review comments, excluded:

generated files
historical release notes
subtrees
translations.

@ppyordanov ppyordanov reopened this Jan 3, 2021
@fanquake
Copy link
Member

fanquake commented Jan 4, 2021

Thanks for your contribution. However to move things along I'm going to fix this up and consolidate it with some other changes. Your changes will still be attributed to you.

@fanquake fanquake closed this Jan 4, 2021
@fanquake fanquake mentioned this pull request Jan 4, 2021
Merged
maflcko pushed a commit that referenced this pull request Jan 5, 2021
Merge #20842: docs: consolidate typo & url fixing
34322b7 
1112035 doc: fix various typos (Ikko Ashimine)
e864084 doc: Use https URLs where possible (Sawyer Billings)

Pull request description:

  Consolidates / fixes the changes from #20762, #20836, #20810. There is no output when  `test/lint/lint-all.sh` is run.

  Closes #20807.

ACKs for top commit:
  MarcoFalke:
    ACK 1112035

Tree-SHA512: 22ca824688758281a74e5ebc6a84a358142351434e34c88c6b36045d2d241ab95fd0958565fd2060f98317e62e683323b5320cc7ec13592bf340e6922294ed78
@bitcoin bitcoin locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ppyordanov @fanquake @michaelfolkson @jonatack @DrahtBot @hebasto