Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: enforce critical class instance attributes in functional tests, fix segwit test specificity #14305

Merged
merged 5 commits into from
Sep 27, 2018
Merged

Tests: enforce critical class instance attributes in functional tests, fix segwit test specificity #14305

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba923e3
test: Fix broken segwit test
practicalswift Sep 23, 2018
1d0ce94
Fix for incorrect version attr set on functional test segwit block.
JustinTArthur Sep 24, 2018
3a4449e
Strictly enforce instance attrs in critical functional test classes.
JustinTArthur Sep 24, 2018
17b42f4
Check for specific tx acceptance failures based on script signature
JustinTArthur Sep 26, 2018
e460232
Document fixed attribute behavior in critical test framework classes.
JustinTArthur Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix for incorrect version attr set on functional test segwit block.
  • Loading branch information
@JustinTArthur
JustinTArthur committed Sep 24, 2018
commit 1d0ce94a54be17b139a052b8e7b4605fe9ac1ecd
2 changes: 1 addition & 1 deletion test/functional/p2p_segwit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def build_next_block(self, version=4):
height = self.nodes[0].getblockcount() + 1
block_time = self.nodes[0].getblockheader(tip)["mediantime"] + 1
block = create_block(int(tip, 16), create_coinbase(height), block_time)
block.version = version
block.nVersion = version
block.rehash()
return block

Expand Down