Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests: feature_bind_port_discover.py is failing #31336

Open
1 task done
andremralves opened this issue Nov 20, 2024 · 1 comment · May be fixed by #31492
Open
1 task done

Functional tests: feature_bind_port_discover.py is failing #31336

andremralves opened this issue Nov 20, 2024 · 1 comment · May be fixed by #31492
Labels
CI failed Tests

Comments

@andremralves
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current behaviour

The test is failing due to Discover() not being able to finding the local addresses "1.1.1.1" and "2.2.2.2".

Expected behaviour

The test should pass. Addr1 and Addr2 should be found.

Steps to reproduce

Run the following commands:

sudo ifconfig lo:0 1.1.1.1/32 up && sudo ifconfig lo:1 2.2.2.2/32 up
./build/test/functional/test_runner.py --ihave1111and2222 feature_bind_port_discover.py

Relevant log output

andre@acer:~/repos/bitcoin$ build/test/functional/test_runner.py --ihave1111and2222 feature_bind_port_discover.py
Temporary test directory at /tmp/test_runner_₿_🏃_20241120_141406
Remaining jobs: [feature_bind_port_discover.py]
1/1 - feature_bind_port_discover.py failed, Duration: 1 s

stdout:
2024-11-20T17:14:06.192000Z TestFramework (INFO): PRNG seed is: 4142310399432710311
2024-11-20T17:14:06.193000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20241120_141406/feature_bind_port_discover_0
2024-11-20T17:14:06.511000Z TestFramework (INFO): Test that if -bind= is not passed then all addresses are added to localaddresses
2024-11-20T17:14:06.512000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/andre/repos/bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/home/andre/repos/bitcoin/build/test/functional/feature_bind_port_discover.py", line 63, in run_test
    assert found_addr1
AssertionError
2024-11-20T17:14:06.563000Z TestFramework (INFO): Stopping nodes
2024-11-20T17:14:06.716000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20241120_141406/feature_bind_port_discover_0
2024-11-20T17:14:06.716000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20241120_141406/feature_bind_port_discover_0/test_framework.log
2024-11-20T17:14:06.716000Z TestFramework (ERROR): 
2024-11-20T17:14:06.716000Z TestFramework (ERROR): Hint: Call /home/andre/repos/bitcoin/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20241120_141406/feature_bind_port_discover_0' to consolidate all logs
2024-11-20T17:14:06.716000Z TestFramework (ERROR): 
2024-11-20T17:14:06.716000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-20T17:14:06.716000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues
2024-11-20T17:14:06.716000Z TestFramework (ERROR): 


stderr:



TEST                          | STATUS    | DURATION

feature_bind_port_discover.py | ✖ Failed  | 1 s

ALL                           | ✖ Failed  | 1 s (accumulated) 
Runtime: 1 s

How did you obtain Bitcoin Core

Compiled from source

What version of Bitcoin Core are you using?

Bitcoin Core daemon version v28.99.0-22ef95dbe3e4

Operating system and version

Ubuntu 22.04

Machine specifications

No response
@andremralves
Copy link
Contributor Author

andremralves commented Nov 20, 2024 •
edited
Loading

I followed the instructions found here:

bitcoin/test/functional/feature_bind_port_discover.py

Lines 12 to 21 in 22ef95d

# We need to bind to a routable address for this test to exercise the relevant code
# and also must have another routable address on another interface which must not
# be named "lo" or "lo0".
# To set these routable addresses on the machine, use:
# Linux:
# ifconfig lo:0 1.1.1.1/32 up && ifconfig lo:1 2.2.2.2/32 up # to set up
# ifconfig lo:0 down && ifconfig lo:1 down # to remove it, after the test
# FreeBSD:
# ifconfig em0 1.1.1.1/32 alias && ifconfig wlan0 2.2.2.2/32 alias # to set up
# ifconfig em0 1.1.1.1 -alias && ifconfig wlan0 2.2.2.2 -alias # to remove it, after the test

After #29984 I think those instructions no longer apply.

@andremralves andremralves mentioned this issue Nov 27, 2024
Open
@andremralves andremralves linked a pull request Dec 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI failed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Execute Discover() when bind=0.0.0.0 or :: is set andremralves/bitcoin
2 participants
@maflcko @andremralves