Skip to content

Commit

Permalink
Do not show call button while the "UI not ready" placeholder is shown
Browse files Browse the repository at this point in the history 
When the "UI not ready" placeholder is shown the other elements in the
tab are hidden using a CSS trick to hide all its next siblings. However,
the call button was prepended to the tab, so it was a previous sibling
of the placeholder and thus it was not hidden. Now it is inserted based
on the chat view instead to ensure that it will be a next sibling of the
placeholder.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
  • Loading branch information
@danxuliu @nickvergessen
danxuliu authored and nickvergessen committed Dec 13, 2018
1 parent e43c12e commit 8905942
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/filesplugin.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@
// Force initial rendering; changes in the room state will
// automatically render the button again from now on.
this._callButton.render();
this._callButton.$el.prependTo(this.$el);
this._callButton.$el.insertBefore(OCA.SpreedMe.app._chatView.$el);
},

setAppStarted: function() {
Expand Down

0 comments on commit 8905942

Please sign in to comment.