Remove log warnings on Request macro registrations #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be bootstrapped twice (e.g. on `php artisan config:cache`)
|
@bilfeldt please merge it. I've discussed it with @pascalbaljet. There doesn't seem to be a "clean" way of warning the user about macro naming conflicts, while the framework boots twice under normal conditions. Using macros in a package could be considered as "risky" anyway, but I understand you're doing it like this, as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #10, Laravel is sometimes bootstrapped twice during the same request cycle. This happens e.g. in
php artisan config:cacheorphp artisan route:cache. We should not log any warnings when trying to re-register macros inCorrelationIdServiceProvider, just silently ignore.