Merge pull request #1681 from sacr3dc0w/master

Account: Product option special characters are not rendered on invoice, order contents and returns
bigcommerce · May 27, 2020 · 989f700 · 989f700
2 parents ca8cbe5 + 9f81f8f
commit 989f700
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+-Account: Product option special characters are not rendered on invoice, order contents and returns [#1681|https://github.com/bigcommerce/cornerstone/pull/1681]
 
 ## 4.5.4 (05-13-2020)
 -Bump jQuery version, expose jquery globally so it doesn't need to be loaded separately [#1671|https://github.com/bigcommerce/cornerstone/pull/1671]

diff --git a/templates/components/account/order-contents.html b/templates/components/account/order-contents.html
@@ -54,7 +54,7 @@ <h6>{{brand.name}}</h6>
                 <dl class="definitionList">
                     {{#each options}}
                         <dt class="definitionList-key">{{name}}:</dt>
-                        <dd class="definitionList-value">{{value}}</dd>
+                        <dd class="definitionList-value">{{{sanitize value}}}</dd>
                     {{/each}}
                 </dl>
                 {{/if}}

diff --git a/templates/components/account/returns-list.html b/templates/components/account/returns-list.html
@@ -37,7 +37,7 @@ <h5 class="account-product-title">{{lang 'account.returns.list.return_number' id
                     <dl class="definitionList">
                         {{#each product.options}}
                             <dt class="definitionList-key">{{name}}:</dt>
-                            <dd class="definitionList-value">{{value}}</dd>
+                            <dd class="definitionList-value">{{{sanitize value}}}</dd>
                         {{/each}}
                     </dl>
                 {{/if}}

diff --git a/templates/pages/account/add-return.html b/templates/pages/account/add-return.html
@@ -37,7 +37,7 @@ <h3 class="account-heading">{{lang 'account.returns.from_order' id=forms.return.
                                             <dl class="definitionList">
                                                 {{#each options}}
                                                 <dt class="definitionList-label">{{name}}:</dt>
-                                                <dd class="definitionList-description">{{value}}</dd>
+                                                <dd class="definitionList-description">{{{sanitize value}}}</dd>
                                                 {{/each}}
                                             </dl>
                                             {{/if}}

diff --git a/templates/pages/account/orders/invoice.html b/templates/pages/account/orders/invoice.html
@@ -120,7 +120,7 @@ <h2 class="InvoiceHeading">{{lang 'invoice.order_items'}}</h2>
                                     <div class="ConfigurableProductRow">
                                         <div class="Label">{{name}}:</div>
                                         <div class="Value"></div>
-                                        <div class="Value">{{value}}</div>
+                                        <div class="Value">{{{sanitize value}}}</div>
                                     </div>
                                 {{/each}}
                             </div>