Fix duplicate contacts during story selection.

benarmstead · Dec 12, 2024 · dadf782 · dadf782
1 parent 010c45d
commit dadf782
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/...org/thoughtcrime/securesms/stories/settings/select/BaseStoryRecipientSelectionFragment.kt b/...org/thoughtcrime/securesms/stories/settings/select/BaseStoryRecipientSelectionFragment.kt
@@ -78,7 +78,10 @@ abstract class BaseStoryRecipientSelectionFragment : Fragment(R.layout.stories_b
 
     viewModel.state.observe(viewLifecycleOwner) {
       if (it.distributionListId == null || it.privateStory != null) {
-        getAttachedContactSelectionFragment().markSelected(it.selection.toSet())
+        if (it.isStartingSelection) {
+          getAttachedContactSelectionFragment().markSelected(it.selection.toSet())
+          viewModel.onStartingSelectionAdded()
+        }
         presentTitle(toolbar, it.selection.size)
       }
     }

diff --git a/...va/org/thoughtcrime/securesms/stories/settings/select/BaseStoryRecipientSelectionState.kt b/...va/org/thoughtcrime/securesms/stories/settings/select/BaseStoryRecipientSelectionState.kt
@@ -7,5 +7,6 @@ import org.thoughtcrime.securesms.recipients.RecipientId
 data class BaseStoryRecipientSelectionState(
   val distributionListId: DistributionListId?,
   val privateStory: DistributionListRecord? = null,
-  val selection: Set<RecipientId> = emptySet()
+  val selection: Set<RecipientId> = emptySet(),
+  val isStartingSelection: Boolean = false
 )
diff --git a/...rg/thoughtcrime/securesms/stories/settings/select/BaseStoryRecipientSelectionViewModel.kt b/...rg/thoughtcrime/securesms/stories/settings/select/BaseStoryRecipientSelectionViewModel.kt
@@ -29,7 +29,7 @@ class BaseStoryRecipientSelectionViewModel(
       disposable += repository.getRecord(distributionListId)
         .subscribe { record ->
           val startingSelection = if (record.privacyMode == DistributionListPrivacyMode.ALL_EXCEPT) record.rawMembers else record.members
-          store.update { it.copy(privateStory = record, selection = it.selection + startingSelection) }
+          store.update { it.copy(privateStory = record, selection = it.selection + startingSelection, isStartingSelection = true) }
         }
     }
   }
@@ -61,6 +61,10 @@ class BaseStoryRecipientSelectionViewModel(
     }
   }
 
+  fun onStartingSelectionAdded() {
+    store.update { it.copy(isStartingSelection = false) }
+  }
+
   sealed class Action {
     data class GoToNextScreen(val recipients: Set<RecipientId>) : Action()
     object ExitFlow : Action()