Address feedback, fix linter warnings and add CI workflow #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marker style should be - `npx awesome-lint README.md`
Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## React"]
Unordered list indentation [Expected: 2; Actual: 4]
Multiple consecutive blank lines [Expected: 1; Actual: 2]
33 tasks
virtualroot
changed the title
|
@virtualroot Should I merge and ask for another review in the upstream PR? |
benallfree
reviewed
Feb 21, 2024
List item link and description must be separated with a dash
|
@benallfree Let's give it a try! 🤞 |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have run these linters and fixed their warnings:
awesome-lint- The awesome list linter.markdownlint-cli2- A Markdown linter.lychee- Finds broken URLs inside Markdown.I added a GitHub workflow to run all the above linters on future pull requests.
I'm also addressing some feedback from sindresorhus/awesome#2895.
I hope these changes help with the awesome-list submission.