Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsh-v3 Start Failed]version.properties file name is duplicated with existing component #736

Open
uni-beta opened this issue Mar 30, 2023 · 1 comment

Comments

@uni-beta
Copy link

in bsh.Interpreter.java

Meeting error like below and start failed, while try to get beanshell version from version.properties
"Can't find resource for bundle java.util.PropertyResourceBundle, key release"

The reason is pre-defined version.properties name is duplicated with existing component. get 'release' and 'build' failed.
ResourceBundle b = ResourceBundle.getBundle("version");
VERSION = b.getString("release") + "." + b.getString("build");

Maybe need fix this issue in master branch.
The quick solution is renaming 'version.properties' to 'bsh-version.properties'

change code like below:
ResourceBundle b = ResourceBundle.getBundle("bsh-version");

@nickl-
Copy link
Member

nickl- commented Apr 1, 2023

Sounds fair enough, do you mind rolling a PR?

Note: it will need to be changed in the pom file too

beanshell/pom.xml

Lines 154 to 165 in 47cbe83

<resources>
<resource>
<directory>src/main/resources</directory>
</resource>
<resource>
<directory>src/conf</directory>
<filtering>true</filtering>
<includes>
<include>version.properties</include>
</includes>
</resource>
</resources>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants