fix: compilation-find-file advice #1696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was late at night so I was not quite verbose :) I asked in emacs reddit before I understood what was happening ( https://www.reddit.com/r/emacs/comments/ouad7r/compilegotoerror_wrong_file/ ) Also, if I may ask, what is the reason of this advice? |
We should check if file doesn't exist in the passed directory and not the default directory. In cases where the compilation happens in another directory (like ./build), the passed filename can be relative (like ../file.cpp) and checking for its existence in the default-directory fails
actondev
force-pushed
the
fix/compilation-find-file-advice
branch
from
18d65e1 to
280c1db
Compare
|
It seems to me this problem is already fix by #1691 |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check if file doesn't exist in the passed directory and not
the default directory. In cases where the compilation happens in
another directory (like ./build), the passed filename can be
relative (like ../file.cpp) and checking for its existence in the
default-directory fails