Support resolving image refs within YAML, not just exact matches of a full string. #134
Conversation
| when using spec->template->metadata->annotations.pod.beta.kubernetes.io/init-containers | ||
| """ | ||
| metadata = '[{"command": ["/some/example/command/example.sh"], "image": "%s"}]' | ||
| sentinel_string = 'XXXXX' |
There was a problem hiding this comment.
Is this whatever:tag and thus unique? If so can you change the form to match this?
Otherwise I'm concerned we'll wind up matching something like bash which might replace more than just the image.
|
@mattmoor any chance you can weigh in here? |
|
/assign |
|
/override continuous-integration/travis-ci/pr |
|
@fejta: Overrode contexts on behalf of fejta: continuous-integration/travis-ci/pr In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Gregg, is this PR still wanted? Can you please address the feedback when you have the chance? Thanks for your patience and contribution! /lifecycle stale |
|
@fejta I will talk with Greg soon and bug him about this. |
|
/remove-lifecycle stale |
|
I am gonna close this due to lack of response. Sent email and pinged yah her. Feel free to reopen! |
This can be useful, e.g., when using
spec->template->metadata->annotations.pod.beta.kubernetes.io/init-containersand embedding image references within a larger JSON string containing a full container description. See the workarounds described in kubernetes/kubernetes#47264 for our motivating example.