Skip to content

Commit

Permalink
Use 'cfg=target' for pusher binary
Browse files Browse the repository at this point in the history
In container_push rule, `_pusher` executable is copied into the output
runfiles, but not directly invoked _by_ the container_push rule.  This
binary could potentially be cross-compiled by other remote executors,
and should use the 'target' config in this action.
  • Loading branch information
anguslees authored and uhthomas committed Jan 18, 2023
1 parent 6975f63 commit e48c7cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion container/push.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ container_push_ = rule(
),
"_pusher": attr.label(
default = "//container/go/cmd/pusher",
cfg = "exec",
cfg = "target",
executable = True,
allow_files = True,
),
Expand Down
2 changes: 1 addition & 1 deletion contrib/push-all.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ container_push = rule(
),
"_pusher": attr.label(
default = Label("//container/go/cmd/pusher"),
cfg = "exec",
cfg = "target",
executable = True,
allow_files = True,
),
Expand Down

0 comments on commit e48c7cc

Please sign in to comment.