Skip to content

Commit

Permalink
README.md: rename client.json -> config.json in one place.
Browse files Browse the repository at this point in the history
I was unlucky to miss all the other references to `config.json` when I was
setting up, so I named my file `client.json`, looking instead only at the label
changed by this commit.

When I later ran a `container_push` target it failed with "permission denied"
issues. I read the shell script generated by `container_push` and saw that it
passes an argument to give the path to the _directory_ of the config file,
rather than the path to the file itself.

That made me realize that I had probably given the file the wrong name; the
Docker client didn't find a `config.json` file in that directory and ignored all
other files.
  • Loading branch information
saser authored and uhthomas committed Aug 20, 2022
1 parent a8aff40 commit 4c1eaab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ docker_toolchain_configure(
# in the client configuration JSON file.
# See https://docs.docker.com/engine/reference/commandline/cli/#configuration-files
# for more details.
client_config="@//path/to/docker:client.json",
client_config="@//path/to/docker:config.json",
)
```
In `BUILD` file:
Expand Down

0 comments on commit 4c1eaab

Please sign in to comment.