Don't treat numbers larger than the JS max number size as number valu…

…es in environment variables (directus#6119) * Incorrect parsing of numeric values in env. * Fixes incorrect parsing of the env. file with numeric values that are outside of Number.MAX_SAFE_INTEGER resulting in unwanted behaviour. - Like wrong client_ids for oauth. (tested with discord oauth) * Removed unnecessary multiple "IF" statements since value can only be ether one of the listed values. * Implements custom_param for OAUTH via grant According to grants documentation you can provide additionally custom parameters to supported OAUTH provider with ```custom_params```. This change allows to add them in JSON format and thus adding multiple parameters. * Fix linter warnings, remove JSON support in favor of nested Grant support Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
baranelitez · Jun 9, 2021 · ad8bd3e · ad8bd3e
1 parent 792281c
commit ad8bd3e
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/api/src/env.ts b/api/src/env.ts
@@ -198,9 +198,16 @@ function processValues(env: Record<string, any>) {
 		}
 
 		if (value === 'true') env[key] = true;
-		if (value === 'false') env[key] = false;
-		if (value === 'null') env[key] = null;
-		if (String(value).startsWith('0') === false && isNaN(value) === false && value.length > 0) env[key] = Number(value);
+		else if (value === 'false') env[key] = false;
+		else if (value === 'null') env[key] = null;
+		else if (
+			String(value).startsWith('0') === false &&
+			isNaN(value) === false &&
+			value.length > 0 &&
+			value < Number.MAX_SAFE_INTEGER // Make sure we don't treat long numeric ID strings as numbers
+		) {
+			env[key] = Number(value);
+		}
 	}
 
 	return env;