enable Style/FormatStringToken rule and add exceptions [skip ci]

bai-yi-bai · Jun 7, 2021 · 122f173 · 122f173
1 parent 61effa1
commit 122f173
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -251,7 +251,8 @@ Style/ExponentialNotation:
 Style/FormatString:
   EnforcedStyle: sprintf
 Style/FormatStringToken:
-  Enabled: false # NOTE annotated style needed to support theming language
+  Enabled: true
+  EnforcedStyle: unannotated
 Style/GlobalStdStream:
   Enabled: true
 Style/GuardClause:

diff --git a/lib/asciidoctor/pdf/converter.rb b/lib/asciidoctor/pdf/converter.rb
@@ -1670,7 +1670,7 @@ def draw_image_border top, w, h, alignment
       def on_image_error _reason, node, target, opts
         log :warn, opts[:message] if opts.key? :message
         alt_text_vars = { alt: (node.attr 'alt'), target: target }
-        alt_text_template = @theme.image_alt_content || '%{link}[%{alt}]%{/link} | <em>%{target}</em>'
+        alt_text_template = @theme.image_alt_content || '%{link}[%{alt}]%{/link} | <em>%{target}</em>' # rubocop:disable Style/FormatStringToken
         return if alt_text_template.empty?
         if (link = node.attr 'link')
           alt_text_vars[:link] = %(<a href="#{link}">)

diff --git a/spec/image_spec.rb b/spec/image_spec.rb
@@ -67,7 +67,7 @@
     end
 
     it 'should be able to customize formatting of alt text using theme' do
-      pdf_theme = { image_alt_content: '%{alt} (%{target})' }
+      pdf_theme = { image_alt_content: '%{alt} (%{target})' } # rubocop:disable Style/FormatStringToken
       (expect do
         pdf = to_pdf 'image::no-such-image.png[Missing Image]', pdf_theme: pdf_theme, analyze: true
         (expect pdf.lines).to eql ['Missing Image (no-such-image.png)']