Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test262 #17021

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Update test262 #17021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FLOW_COMMIT = b7f56844ec194c8901a18d11e6b356dd56b3bdeb
TEST262_COMMIT = eefc5cf367b999768445432e167606fd1acf1734
TEST262_COMMIT = dc0082c5ea347e5ecb585c1d7ebf4555aa429528
TYPESCRIPT_COMMIT = d87d0adcd30ac285393bf3bfbbb4d94d50c4f3c9

SOURCES = packages codemods eslint
Expand Down
23 changes: 18 additions & 5 deletions scripts/parser-tests/test262/allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,22 @@ language/import/import-attributes/json-named-bindings.js(default)
language/import/import-attributes/json-named-bindings.js(strict mode)


# 4 valid programs produced a parsing error
# 17 valid programs produced a parsing error

language/import/import-defer/errors/resolution-error/import-defer-of-missing-module-fails.js(default)
language/import/import-defer/errors/resolution-error/import-defer-of-missing-module-fails.js(strict mode)
language/import/import-defer/errors/syntax-error/import-defer-of-syntax-error-fails.js(default)
language/import/import-defer/errors/syntax-error/import-defer-of-syntax-error-fails.js(strict mode)
staging/sm/String/make-normalize-generateddata-input.py(default)
staging/sm/String/make-normalize-generateddata-input.py(strict mode)
staging/sm/extensions/inc-dec-functioncall.js(default)
staging/sm/lexical-environment/block-scoped-functions-deprecated-redecl.js(default)
staging/sm/lexical-environment/block-scoped-functions-hoisted-tdz.js(default)
staging/sm/lexical-environment/var-in-catch-body-annex-b-eval.js(default)
staging/sm/module/bug1693261-async.mjs(default)
staging/sm/module/bug1693261-async.mjs(strict mode)
staging/sm/module/bug1693261-c1.mjs(default)
staging/sm/module/bug1693261-c1.mjs(strict mode)
staging/sm/module/bug1693261-c2.mjs(default)
staging/sm/module/bug1693261-c2.mjs(strict mode)
staging/sm/module/bug1693261-x.mjs(default)
staging/sm/module/bug1693261-x.mjs(strict mode)
staging/sm/regress/regress-563221.js(default)
staging/sm/regress/regress-609617.js(default)
staging/sm/statements/for-of-iterator-close.js(default)
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all broken tests, and not Babel bugs.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tc39/test262#4345, tc39/test262#4346, tc39/test262#4347

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/babel/babel/pull/17021/files#diff-e1ef5153354cf3d7e9b62bf220450240b6e16c6535eaee694e61043ab544d110R11-R12
There seem to be two .py files, do you know what the reason is?

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just asked to the maintainers. I think it's a bug in test262: all files except for those containing _FIXTURE are meant to be interpreted as JS tests, but I'll wait for them to answer.

1 change: 1 addition & 0 deletions scripts/parser-tests/test262/ignored-features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
"import.meta",
"intl-normative-optional",
"iterator-helpers",
"iterator-sequencing",
"json-modules",
"json-parse-with-source",
"json-superset",
Expand Down
Loading