Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: TSTypeOperator: keyof (#16799) #17009

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feature: TSTypeOperator: keyof (#16799) #17009

wants to merge 7 commits into from

Conversation

coderaiser
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #16799
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 5, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58577

@coderaiser coderaiser force-pushed the feature/ts-type-operator-keyof branch from 0f8f3a8 to 4267b15 Compare December 5, 2024 20:43
liuxingbaoyu
liuxingbaoyu approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories area: typescript pkg: types PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release labels Dec 6, 2024
@liuxingbaoyu
Copy link
Member

Since a TSTypeOperator without operator is not valid, maybe we can not treat it as a new feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: typescript pkg: types PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TSTypeQuery ignores second argument: operator
4 participants
@coderaiser @babel-bot @liuxingbaoyu @JLHwung