Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple TypeScript projects #16430

Merged
merged 28 commits into from
Apr 24, 2024
Merged

Use multiple TypeScript projects #16430

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
95ed395
Migrate to TS project references
nicolo-ribaudo Apr 13, 2024
e203f5d
Commit generated tsconfig.json
nicolo-ribaudo Apr 13, 2024
9fe20b6
Add missing `@babel/core` dep to helper-plugin-utils
nicolo-ribaudo Apr 13, 2024
63cf90e
Fix standalone type checking
nicolo-ribaudo Apr 13, 2024
d2068cb
Fix generation
nicolo-ribaudo Apr 13, 2024
c2539c7
Avoid ts-expect-error in dts files
nicolo-ribaudo Apr 14, 2024
a836925
Only clean tsbuildinfo on prepublish, or manually
nicolo-ribaudo Apr 14, 2024
5580fbb
Add missing `include: []` to root tsconfig.json
nicolo-ribaudo Apr 14, 2024
6b61c46
Add script to run tsc on multiple cores
nicolo-ribaudo Apr 14, 2024
bcd8ee4
Reduce logging
nicolo-ribaudo Apr 14, 2024
38f7cad
Make types faster
nicolo-ribaudo Apr 18, 2024
116d9f4
Only chech .d.ts files in the root project
nicolo-ribaudo Apr 22, 2024
57e42cd
Copy .d.ts files from `src` to `dts`
nicolo-ribaudo Apr 22, 2024
e2ebc5e
Remove unnecessary /// ref
nicolo-ribaudo Apr 22, 2024
658b19c
Rermove ts-expect-error that hides error in .d.ts
nicolo-ribaudo Apr 22, 2024
4a88eff
Do not double-check `.d.ts` files in `src`
nicolo-ribaudo Apr 22, 2024
e733be5
Update ts-node to support array in tsconfig.json#extends
nicolo-ribaudo Apr 22, 2024
2e0464b
Run tsc in parallel in `make tscheck`
nicolo-ribaudo Apr 22, 2024
9ea2520
Sort NodePath members from least to most complex
nicolo-ribaudo Apr 22, 2024
37112aa
Actually generate the generated file
nicolo-ribaudo Apr 22, 2024
bd75691
Pre-run tsc before linting
nicolo-ribaudo Apr 22, 2024
2ecb92a
Run tsc before linting
nicolo-ribaudo Apr 22, 2024
8963032
max-old-space-size=4096
nicolo-ribaudo Apr 22, 2024
229da63
Run ESLint in chunks
nicolo-ribaudo Apr 22, 2024
7641357
cleanup
nicolo-ribaudo Apr 22, 2024
6cf9532
Actually lint on CI
nicolo-ribaudo Apr 22, 2024
a210014
fix win
liuxingbaoyu Apr 22, 2024
179ea0e
Dedupe reference paths in top-level tsconfig
nicolo-ribaudo Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reduce logging
  • Loading branch information
@nicolo-ribaudo
nicolo-ribaudo committed Apr 22, 2024
commit bcd8ee4a687453d09d82e52bcd616f0240837f4e
2 changes: 0 additions & 2 deletions scripts/parallel-tsc/tsc.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's worth noting that if you're not doing a --fix run then you can actually pass the ts.Program instance and reuse the types for the lint run.

https://typescript-eslint.io/packages/parser#programs

This would net you a modest speedup by skipping one "typecheck" cycle.
Note - you'd need to switch from invoking tsc via a child process to directly using the typescript APIs to do this though.
Thought it was worth mentioning in case you want speeeeed

Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ class Pool {
}
this.#pending = this.#pending.filter((_, i) => !toRemove.has(i));

console.log(`RUN node ${this.#filename} -b ${tasks.join(" ")}`);

const taskProcess = cp.fork(this.#filename, ["-b", ...tasks, "--pretty"], {
stdio: this.#showOutput(tasks) ? "inherit" : "ignore",
});
Expand Down