Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle __proto__ exports name in CJS/AMD/UMD #16015

Merged
merged 4 commits into from
Oct 13, 2023
Merged

fix: handle __proto__ exports name in CJS/AMD/UMD #16015

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5ceced
fix: handle `__proto__` exports name in CJS/AMD/UMD
magic-akari Oct 1, 2023
880d48a
chore: only compare with `__proto__`
magic-akari Oct 2, 2023
384c861
chore: use `cjs-module-lexer` friendly syntax
magic-akari Oct 2, 2023
7dee951
Add test for `export ... from`
nicolo-ribaudo Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: use cjs-module-lexer friendly syntax
  • Loading branch information
@magic-akari @nicolo-ribaudo
magic-akari authored and nicolo-ribaudo committed Oct 13, 2023
commit 384c8617995d7a801618f577b57e836d478db0ec
2 changes: 1 addition & 1 deletion packages/babel-helper-module-transforms/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ function buildExportInitializationStatements(
const InitTemplate = {
computed: template.expression`EXPORTS["NAME"] = VALUE`,
default: template.expression`EXPORTS.NAME = VALUE`,
define: template.expression`Object.defineProperty(EXPORTS, "NAME", { enumerable:true, writable: true, value: void 0 })["NAME"] = VALUE`,
define: template.expression`Object.defineProperty(EXPORTS, "NAME", { enumerable:true, value: void 0, writable: true })["NAME"] = VALUE`,
};

function buildInitStatement(
Expand Down
4 changes: 2 additions & 2 deletions packages/babel-plugin-transform-modules-amd/test/fixtures/amd/export-named-6/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ define(["exports", "./input.js"], function (_exports, _input) {
});
_exports.a = Object.defineProperty(_exports, "__proto__", {
enumerable: true,
writable: true,
value: void 0
value: void 0,
writable: true
})["__proto__"] = _exports._ = void 0;
const __proto__ = _exports.__proto__ = null;
const a = _exports.a = 1;
Expand Down
4 changes: 2 additions & 2 deletions ...es/babel-plugin-transform-modules-commonjs/test/fixtures/interop/export-named-6/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ Object.defineProperty(exports, "__esModule", {
});
exports.a = Object.defineProperty(exports, "__proto__", {
enumerable: true,
writable: true,
value: void 0
value: void 0,
writable: true
})["__proto__"] = exports._ = void 0;
var _input = require("./input.js");
const __proto__ = exports.__proto__ = null;
Expand Down
4 changes: 2 additions & 2 deletions packages/babel-plugin-transform-modules-umd/test/fixtures/umd/export-named-6/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
});
_exports.a = Object.defineProperty(_exports, "__proto__", {
enumerable: true,
writable: true,
value: void 0
value: void 0,
writable: true
})["__proto__"] = _exports._ = void 0;
const __proto__ = _exports.__proto__ = null;
const a = _exports.a = 1;
Expand Down