Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ParseError Much Simpler now that we can use TypeScript #14796

Merged
merged 8 commits into from
Jul 25, 2022
Merged

Make ParseError Much Simpler now that we can use TypeScript #14796

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc24c3f
Dramatically simplify ParseError and associated ParseErrorTemplates n…
tolmasky Jul 25, 2022
14e7796
Fix lint error.
tolmasky Jul 25, 2022
9ed5f69
A minor change to make this less verbose.
tolmasky Jul 25, 2022
b8ed13b
Add a comment explaining why we inline the type definition instead of…
tolmasky Jul 25, 2022
ae3d447
Use inferred type instead of unknown.
tolmasky Jul 25, 2022
adcef9c
Better comments and clean up some errors in a better way.
tolmasky Jul 25, 2022
afbaa2c
Use SyntaxPlugin everywhere. TypeScript doesn't seem to care either w…
tolmasky Jul 25, 2022
c5f4bba
Use const enum for ParseErrorCode.
tolmasky Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a comment explaining why we inline the type definition instead of… 
… factoring it out.

Reviewed by @tolmasky.
  • Loading branch information
@tolmasky
tolmasky committed Jul 25, 2022
commit b8ed13b839f98f443dcfa01708ee110d63d9ee07
7 changes: 7 additions & 0 deletions packages/babel-parser/src/parse-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ type ParseErrorTemplate =

type ParseErrorTemplates = { [reasonCode: string]: ParseErrorTemplate };

// This is the templated form of `ParseErrorEnum`.
//
// Note: We could factor out the return type calculation into something like
// `ParseErrorConstructor<T extends ParseErrorTemplates>`, and then we could
// reuse it in the non-templated form of `ParseErrorEnum`, but TypeScript
// doesn't seem to drill down that far when showing you the computed type of
// an object in an editor, so we'll leave it inlined for now.
export function ParseErrorEnum(a: TemplateStringsArray): <
T extends ParseErrorTemplates,
>(
Expand Down